From 2b61b75f0c54f1abca813ee93be45806d3814316 Mon Sep 17 00:00:00 2001
From: Henrik Giesel <hengiesel@gmail.com>
Date: Fri, 10 Dec 2021 15:09:07 +0100
Subject: [PATCH] Avoid bubbling down the duplicate logic into EditorField

---
 ts/editor/DuplicateLink.svelte    | 23 +++++++++++++++++++++++
 ts/editor/EditorField.svelte      | 17 +----------------
 ts/editor/OldEditorAdapter.svelte |  8 +++++++-
 3 files changed, 31 insertions(+), 17 deletions(-)
 create mode 100644 ts/editor/DuplicateLink.svelte

diff --git a/ts/editor/DuplicateLink.svelte b/ts/editor/DuplicateLink.svelte
new file mode 100644
index 000000000..9f1d5f359
--- /dev/null
+++ b/ts/editor/DuplicateLink.svelte
@@ -0,0 +1,23 @@
+<!--
+Copyright: Ankitects Pty Ltd and contributors
+License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
+-->
+<script lang="ts">
+    import * as tr from "../lib/ftl";
+    import { bridgeCommand } from "../lib/bridgecommand";
+</script>
+
+<a
+    class="duplicate-link"
+    href="/#"
+    tabindex="-1"
+    on:click={() => bridgeCommand("dupes")}
+>
+    {tr.editingShowDuplicates()}
+</a>
+
+<style lang="scss">
+    .duplicate-link {
+        color: var(--highlight-color);
+    }
+</style>
diff --git a/ts/editor/EditorField.svelte b/ts/editor/EditorField.svelte
index 7b1fd6ab1..81aff62a2 100644
--- a/ts/editor/EditorField.svelte
+++ b/ts/editor/EditorField.svelte
@@ -28,7 +28,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 </script>
 
 <script lang="ts">
-    import * as tr from "../lib/ftl";
     import EditingArea from "./EditingArea.svelte";
     import LabelContainer from "./LabelContainer.svelte";
     import LabelDescription from "./LabelDescription.svelte";
@@ -45,7 +44,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     export let content: Writable<string>;
     export let field: FieldData;
     export let autofocus = false;
-    export let dupes = false;
 
     export let api: (Partial<EditorFieldAPI> & Destroyable) | undefined = undefined;
 
@@ -77,7 +75,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     on:focusout
     on:click={() => editingArea.focus?.()}
 >
-    <LabelContainer --label-color={dupes ? "var(--flag1-bg)" : "transparent"}>
+    <LabelContainer>
         <span>
             <LabelName>
                 {field.name}
@@ -86,11 +84,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
                 <LabelDescription description={field.description} />
             {/if}
         </span>
-        {#if dupes}
-            <span class="dupes" on:click={() => globalThis.pycmd("dupes")}
-                >{tr.editingShowDuplicates()}
-            </span>
-        {/if}
         <FieldState><slot name="field-state" /></FieldState>
     </LabelContainer>
     <EditingArea
@@ -120,12 +113,4 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             box-shadow: 0 0 0 3px var(--focus-shadow);
         }
     }
-
-    .dupes {
-        cursor: pointer;
-        color: var(--highlight-fg);
-        &:hover {
-            text-decoration: underline;
-        }
-    }
 </style>
diff --git a/ts/editor/OldEditorAdapter.svelte b/ts/editor/OldEditorAdapter.svelte
index 9fccff1c0..306b86b3a 100644
--- a/ts/editor/OldEditorAdapter.svelte
+++ b/ts/editor/OldEditorAdapter.svelte
@@ -50,6 +50,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     import Notification from "./Notification.svelte";
     import Absolute from "../components/Absolute.svelte";
     import Badge from "../components/Badge.svelte";
+    import DuplicateLink from "./DuplicateLink.svelte";
 
     import DecoratedElements from "./DecoratedElements.svelte";
     import RichTextInput from "./RichTextInput.svelte";
@@ -283,7 +284,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
                     {field}
                     content={fieldStores[index]}
                     autofocus={index === focusTo}
-                    dupes={cols[index] === "dupe"}
                     api={fields[index]}
                     on:focusin={() => {
                         $currentField = fields[index];
@@ -295,8 +295,14 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
                             `blur:${index}:${getNoteId()}:${get(fieldStores[index])}`,
                         );
                     }}
+                    --label-color={cols[index] === "dupe"
+                        ? "var(--flag1-bg)"
+                        : "transparent"}
                 >
                     <svelte:fragment slot="field-state">
+                        {#if cols[index] === "dupe"}
+                            <DuplicateLink />
+                        {/if}
                         <RichTextBadge bind:off={richTextsHidden[index]} />
                         <PlainTextBadge bind:off={plainTextsHidden[index]} />
                         {#if stickies}