GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Fix Image field not hidden until user selects an image (#2960)

Browse source
This commit is contained in:
Abdo 2024-01-23 07:24:12 +03:00 committed by GitHub
parent 462c9e76b1
commit 0291847712
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
qt/aqt/editor.py
View file

@ -571,6 +571,7 @@ require("anki/ui").loaded.then(() => require("anki/NoteEditor").instances[0].too
js = f""" js = f"""
saveSession(); saveSession();
setFields({json.dumps(data)}); setFields({json.dumps(data)});
setIsImageOcclusion({json.dumps(self.current_notetype_is_image_occlusion())});
setNotetypeMeta({json.dumps(notetype_meta)}); setNotetypeMeta({json.dumps(notetype_meta)});
setCollapsed({json.dumps(collapsed)}); setCollapsed({json.dumps(collapsed)});
setPlainTexts({json.dumps(plain_texts)}); setPlainTexts({json.dumps(plain_texts)});
@ -585,7 +586,6 @@ require("anki/ui").loaded.then(() => require("anki/NoteEditor").instances[0].too
setShrinkImages({json.dumps(self.mw.col.get_config("shrinkEditorImages", True))}); setShrinkImages({json.dumps(self.mw.col.get_config("shrinkEditorImages", True))});
setCloseHTMLTags({json.dumps(self.mw.col.get_config("closeHTMLTags", True))}); setCloseHTMLTags({json.dumps(self.mw.col.get_config("closeHTMLTags", True))});
triggerChanges(); triggerChanges();
setIsImageOcclusion({json.dumps(self.current_notetype_is_image_occlusion())});
""" """
if self.addMode: if self.addMode:

10
ts/editor/NoteEditor.svelte
View file

@ -233,6 +233,11 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
if (sessionOptions[id]?.modTimeOfNotetype !== modTime) { if (sessionOptions[id]?.modTimeOfNotetype !== modTime) {
delete sessionOptions[id]; delete sessionOptions[id];
} }
if (isImageOcclusion) {
getImageOcclusionFields({
notetypeId: BigInt(notetypeMeta.id),
}).then((r) => (ioFields = r.fields!));
}
} }
function getNoteId(): number | null { function getNoteId(): number | null {
@ -415,10 +420,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
async function setupMaskEditor(options: { html: string; mode: IOMode }) { async function setupMaskEditor(options: { html: string; mode: IOMode }) {
imageOcclusionMode = undefined; imageOcclusionMode = undefined;
const getIoFields = getImageOcclusionFields({ await tick();
notetypeId: BigInt(notetypeMeta.id),
}).then((r) => (ioFields = r.fields!));
await Promise.all([tick(), getIoFields]);
imageOcclusionMode = options.mode; imageOcclusionMode = options.mode;
if (options.mode.kind === "add") { if (options.mode.kind === "add") {
fieldStores[ioFields.image].set(options.html); fieldStores[ioFields.image].set(options.html);