GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-20 23:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Add legacy arg to ExportAnkiPackage

Browse source 
Currently not exposed on the frontend
This commit is contained in:
Damien Elmes 2022-04-26 21:30:47 +10:00
parent ede9698aea
commit 055b404165
5 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
proto/anki/import_export.proto
View file

@ -55,10 +55,11 @@ message ExportAnkiPackageRequest {
string out_path = 1; string out_path = 1;
bool with_scheduling = 2; bool with_scheduling = 2;
bool with_media = 3; bool with_media = 3;
bool legacy = 4;
oneof selector { oneof selector {
generic.Empty whole_collection = 4; generic.Empty whole_collection = 5;
int64 deck_id = 5; int64 deck_id = 6;
notes.NoteIds note_ids = 6; notes.NoteIds note_ids = 7;
} }
} }

1
pylib/anki/collection.py
View file

@ -389,6 +389,7 @@ class Collection(DeprecatedNamesMixin):
out_path=out_path, out_path=out_path,
with_scheduling=with_scheduling, with_scheduling=with_scheduling,
with_media=with_media, with_media=with_media,
legacy=True,
**selector_kwarg, **selector_kwarg,
) )
return self._backend.export_anki_package(request) return self._backend.export_anki_package(request)

1
rslib/src/backend/import_export.rs
View file

@ -66,6 +66,7 @@ impl ImportExportService for Backend {
SearchNode::from_selector(selector), SearchNode::from_selector(selector),
input.with_scheduling, input.with_scheduling,
input.with_media, input.with_media,
input.legacy,
None, None,
self.export_progress_fn(), self.export_progress_fn(),
) )

8
rslib/src/import_export/package/apkg/export.rs
View file

@ -24,12 +24,14 @@ use crate::{
impl Collection { impl Collection {
/// Returns number of exported notes. /// Returns number of exported notes.
#[allow(clippy::too_many_arguments)]
pub fn export_apkg( pub fn export_apkg(
&mut self, &mut self,
out_path: impl AsRef<Path>, out_path: impl AsRef<Path>,
search: impl TryIntoSearch, search: impl TryIntoSearch,
with_scheduling: bool, with_scheduling: bool,
with_media: bool, with_media: bool,
legacy: bool,
media_fn: Option<Box<dyn FnOnce(HashSet<PathBuf>) -> MediaIter>>, media_fn: Option<Box<dyn FnOnce(HashSet<PathBuf>) -> MediaIter>>,
progress_fn: impl FnMut(usize) -> Result<()>, progress_fn: impl FnMut(usize) -> Result<()>,
) -> Result<usize> { ) -> Result<usize> {
@ -54,7 +56,11 @@ impl Collection {
let col_size = temp_col.as_file().metadata()?.len() as usize; let col_size = temp_col.as_file().metadata()?.len() as usize;
export_collection( export_collection(
Meta::new_legacy(), if legacy {
Meta::new_legacy()
} else {
Meta::new()
},
temp_apkg.path(), temp_apkg.path(),
&mut temp_col, &mut temp_col,
col_size, col_size,

1
rslib/src/import_export/package/apkg/tests.rs
View file

@ -35,6 +35,7 @@ fn roundtrip() {
SearchNode::from_deck_name("parent::sample"), SearchNode::from_deck_name("parent::sample"),
true, true,
true, true,
true,
None, None,
|_| Ok(()), |_| Ok(()),
) )