From 0acbf3e9eb8af19227794d328dcb1f9c88ecd3c1 Mon Sep 17 00:00:00 2001
From: Henrik Giesel <hengiesel@gmail.com>
Date: Sun, 27 Jun 2021 16:32:39 +0200
Subject: [PATCH] Export blink as a function, works more reliably

---
 ts/editor/Tag.svelte       | 16 +++++++++-------
 ts/editor/TagEditor.svelte |  4 ++--
 ts/editor/tags.ts          |  6 ++++--
 3 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/ts/editor/Tag.svelte b/ts/editor/Tag.svelte
index bc713a5a0..1f8331843 100644
--- a/ts/editor/Tag.svelte
+++ b/ts/editor/Tag.svelte
@@ -8,23 +8,25 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     import { deleteIcon } from "./icons";
 
     export let name: string;
-    export let blink: boolean = false;
 
     const dispatch = createEventDispatcher();
 
-    $: if (blink) {
-        setTimeout(() => (blink = false), 300);
-    }
-
     function deleteTag(event: Event): void {
         dispatch("tagdelete");
         event.stopPropagation();
     }
+
+    let isBlink: boolean = false;
+
+    export function blink() {
+        isBlink = true;
+        setTimeout(() => (isBlink = false), 300);
+    }
 </script>
 
 <button
     class="d-inline-flex align-items-center tag text-nowrap rounded ps-2 pe-1 me-1"
-    class:blink
+    class:blink={isBlink}
     tabindex="-1"
     on:click
 >
@@ -62,7 +64,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         }
 
         &.blink {
-            animation: blink 0.2s linear;
+            animation: blink 0.3s linear;
         }
     }
 </style>
diff --git a/ts/editor/TagEditor.svelte b/ts/editor/TagEditor.svelte
index c08990c62..08011dfb3 100644
--- a/ts/editor/TagEditor.svelte
+++ b/ts/editor/TagEditor.svelte
@@ -64,7 +64,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
         const contained = names.indexOf(newName);
         if (contained >= 0) {
-            tags[contained].blink = true;
+            tags[contained].blink();
             return false;
         }
 
@@ -101,7 +101,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         const deleted = tags.splice(index, 1)[0];
         tags = tags;
 
-        console.log('dt', activeAfterBlur, index)
+        console.log("dt", activeAfterBlur, index);
         if (active !== null && active > index) {
             active--;
         }
diff --git a/ts/editor/tags.ts b/ts/editor/tags.ts
index 7a0446c1b..dcffe630a 100644
--- a/ts/editor/tags.ts
+++ b/ts/editor/tags.ts
@@ -18,14 +18,16 @@ export function normalizeTagname(tagname: string): string {
 export interface Tag {
     id: string;
     name: string;
-    blink: boolean;
+    blink: () => void;
 }
 
+const noop = () => {};
+
 export function attachId(name: string): Tag {
     return {
         id: Math.random().toString(36).substring(2),
         name,
-        blink: false,
+        blink: noop,
     };
 }