GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-13 22:13:58 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Treat play_file() and co as internal routines without protection

Browse source 
Our code and add-ons need a way to play audio from arbitrary locations.
I propose we treat the _tag API as dangerous, and the _file API as
trusted.

Related: #4058
This commit is contained in:
Damien Elmes 2025-06-05 11:19:27 +07:00
parent 8add993fca
commit 0e7580949d
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
qt/aqt/sound.py
View file

@ -177,16 +177,28 @@ class AVPlayer:
self._stop_if_playing() self._stop_if_playing()
def play_file(self, filename: str) -> None: def play_file(self, filename: str) -> None:
self.play_tags([SoundOrVideoTag(filename=os.path.basename(filename))]) """Play the provided path.
SECURITY: Filename may be an arbitrary path. For content coming from a collection,
use play_tag() instead."""
self.play_tags([SoundOrVideoTag(filename=filename)])
def play_file_with_caller(self, filename: str, caller: Any) -> None: def play_file_with_caller(self, filename: str, caller: Any) -> None:
"""Play the provided path, noting down the caller.
SECURITY: Filename may be an arbitrary path. For content coming from a collection,
use play_tag() instead."""
if self.current_caller: if self.current_caller:
self.current_caller_interrupted = True self.current_caller_interrupted = True
self.current_caller = caller self.current_caller = caller
self.play_file(filename) self.play_file(filename)
def insert_file(self, filename: str) -> None: def insert_file(self, filename: str) -> None:
self._enqueued.insert(0, SoundOrVideoTag(filename=os.path.basename(filename))) """Place the provided path at the top of the playlist.
SECURITY: Filename may be an arbitrary path. For content coming from a collection,
use play_tag() instead."""
self._enqueued.insert(0, SoundOrVideoTag(filename=filename))
self._play_next_if_idle() self._play_next_if_idle()
def toggle_pause(self) -> None: def toggle_pause(self) -> None: