GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-22 07:52:24 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Add cursory type annotations for aqt.DialogManager

Browse source 
Typing DialogManager._dialogs properly would require more extensive
changes which could break a number of add-ons
This commit is contained in:
Glutanimate 2020-03-07 17:29:37 +01:00
parent 4290bc81eb
commit 0f9683a850
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
qt/aqt/__init__.py
View file

@ -10,7 +10,7 @@ import os
import sys
import tempfile
import traceback
from typing import Any, Optional
from typing import Any, Dict, Optional
import anki.buildinfo
import anki.lang
@ -69,7 +69,7 @@ from aqt import stats, about, preferences, mediasync # isort:skip
class DialogManager:
_dialogs = {
_dialogs: Dict[str, list] = {
"AddCards": [addcards.AddCards, None],
"Browser": [browser.Browser, None],
"EditCurrent": [editcurrent.EditCurrent, None],
@ -79,7 +79,7 @@ class DialogManager:
"sync_log": [mediasync.MediaSyncDialog, None],
}
def open(self, name, *args):
def open(self, name: str, *args: Any) -> Any:
(creator, instance) = self._dialogs[name]
if instance:
if instance.windowState() & Qt.WindowMinimized:
@ -94,17 +94,17 @@ class DialogManager:
self._dialogs[name][1] = instance
return instance
def markClosed(self, name):
def markClosed(self, name: str):
self._dialogs[name] = [self._dialogs[name][0], None]
def allClosed(self):
return not any(x[1] for x in self._dialogs.values())
def closeAll(self, onsuccess):
def closeAll(self, onsuccess: Callable[[], None]) -> Optional[bool]:
# can we close immediately?
if self.allClosed():
onsuccess()
return
return None
# ask all windows to close and await a reply
for (name, (creator, instance)) in self._dialogs.items():