fix add; update modelchooser

aqt/modelchooser.py

@@ -160,29 +160,27 @@ class ModelChooser(QHBoxLayout):
 
 class AddModel(QDialog):
 
-    def __init__(self, parent, main, deck):
+    def __init__(self, mw, parent=None):
-        QDialog.__init__(self, parent, Qt.Window)
+        self.parent = parent or mw
-        self.parent = parent
+        self.mw = mw
-        if not main:
+        self.deck = mw.deck
-            main = parent
+        QDialog.__init__(self, self.parent, Qt.Window)
-        self.main = main
         self.model = None
-        self.deck = deck
+        self.dialog = aqt.forms.addmodel.Ui_Dialog()
-        self.dialog = aqt.forms.addmodel.Ui_AddModel()
         self.dialog.setupUi(self)
+        # standard models
         self.models = []
-        names = stdmodels.models.keys()
+        for (name, func) in stdmodels.models:
-        names.sort()
+            item = QListWidgetItem(_("Add: %s") % name)
-        for name in names:
-            m = stdmodels.byName(name)
-            item = QListWidgetItem(_("Add: %s") % m.name)
             self.dialog.models.addItem(item)
-            self.models.append((True, m))
+            self.models.append((True, func))
-        # add local decks
+        # add copies
-        models = sorted(deck.models, key=attrgetter("name"))
+        mids = self.deck.db.list("select id from models order by name")
-        for m in models:
+        for m in [self.deck.getModel(mid, False) for mid in mids]:
+            m.id = None
             item = QListWidgetItem(_("Copy: %s") % m.name)
             self.dialog.models.addItem(item)
+            m.name = _("%s copy") % m.name
             self.models.append((False, m))
         self.dialog.models.setCurrentRow(0)
         # the list widget will swallow the enter key
@@ -191,16 +189,22 @@ class AddModel(QDialog):
         # help
         self.connect(self.dialog.buttonBox, SIGNAL("helpRequested()"), self.onHelp)
 
-    def getModel(self):
+    def get(self):
         self.exec_()
         return self.model
 
+    def reject(self):
+        self.accept()
+
     def accept(self):
-        (isStd, self.model) = self.models[
+        (isStd, model) = self.models[self.dialog.models.currentRow()]
-            self.dialog.models.currentRow()]
+        if isStd:
-        if not isStd:
+            # create
-            # not a standard model, so duplicate
+            self.model = model(self.deck)
-            self.model = self.deck.copyModel(self.model)
+        else:
+            # add copy to deck
+            self.mw.deck.addModel(model)
+            self.model = model
         QDialog.accept(self)
 
     def onHelp(self):

aqt/models.py

@@ -54,7 +54,7 @@ class Models(QDialog):
         self.model = self.models[idx]
 
     def onAdd(self):
-        m = aqt.modelchooser.AddModel(self, self.parent, self.d).getModel()
+        m = aqt.modelchooser.AddModel(self.mw, self).get()
         if m:
             self.deck.addModel(m)
             self.updateModelsList()

designer/addmodel.ui

@@ -1,7 +1,8 @@
-<ui version="4.0" >
+<?xml version="1.0" encoding="UTF-8"?>
- <class>AddModel</class>
+<ui version="4.0">
- <widget class="QDialog" name="AddModel" >
+ <class>Dialog</class>
-  <property name="geometry" >
+ <widget class="QDialog" name="Dialog">
+  <property name="geometry">
    <rect>
     <x>0</x>
     <y>0</y>
@@ -9,27 +10,27 @@
     <height>269</height>
    </rect>
   </property>
-  <property name="windowTitle" >
+  <property name="windowTitle">
    <string>Add Model</string>
   </property>
-  <layout class="QVBoxLayout" >
+  <layout class="QVBoxLayout">
    <item>
-    <widget class="QGroupBox" name="groupBox" >
+    <widget class="QGroupBox" name="groupBox">
-     <property name="title" >
+     <property name="title">
       <string/>
      </property>
-     <layout class="QVBoxLayout" >
+     <layout class="QVBoxLayout">
       <item>
-       <widget class="QListWidget" name="models" >
+       <widget class="QListWidget" name="models">
-        <property name="font" >
+        <property name="font">
          <font>
           <pointsize>12</pointsize>
          </font>
         </property>
-        <property name="editTriggers" >
+        <property name="editTriggers">
          <set>QAbstractItemView::NoEditTriggers</set>
         </property>
-        <property name="tabKeyNavigation" >
+        <property name="tabKeyNavigation">
          <bool>true</bool>
         </property>
        </widget>
@@ -38,12 +39,12 @@
     </widget>
    </item>
    <item>
-    <widget class="QDialogButtonBox" name="buttonBox" >
+    <widget class="QDialogButtonBox" name="buttonBox">
-     <property name="orientation" >
+     <property name="orientation">
       <enum>Qt::Horizontal</enum>
      </property>
-     <property name="standardButtons" >
+     <property name="standardButtons">
-      <set>QDialogButtonBox::Cancel|QDialogButtonBox::Help|QDialogButtonBox::Ok</set>
+      <set>QDialogButtonBox::Help|QDialogButtonBox::Ok</set>
      </property>
     </widget>
    </item>
@@ -54,14 +55,14 @@
   <connection>
    <sender>buttonBox</sender>
    <signal>accepted()</signal>
-   <receiver>AddModel</receiver>
+   <receiver>Dialog</receiver>
    <slot>accept()</slot>
    <hints>
-    <hint type="sourcelabel" >
+    <hint type="sourcelabel">
      <x>266</x>
      <y>353</y>
     </hint>
-    <hint type="destinationlabel" >
+    <hint type="destinationlabel">
      <x>157</x>
      <y>274</y>
     </hint>
@@ -70,14 +71,14 @@
   <connection>
    <sender>buttonBox</sender>
    <signal>rejected()</signal>
-   <receiver>AddModel</receiver>
+   <receiver>Dialog</receiver>
    <slot>reject()</slot>
    <hints>
-    <hint type="sourcelabel" >
+    <hint type="sourcelabel">
      <x>334</x>
      <y>353</y>
     </hint>
-    <hint type="destinationlabel" >
+    <hint type="destinationlabel">
      <x>286</x>
      <y>274</y>
     </hint>