GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 14:02:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Replace 'const' with 'let' on global scope functions

Browse source 
Also use const where possible.
This commit is contained in:
Michal Pokorný (Rai) 2019-12-21 11:18:58 +01:00
parent ce59fad160
commit 16d97c8e0a
1 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
ts/src/editor.ts
View file

@ -14,7 +14,7 @@ declare interface String {
/* kept for compatibility with add-ons */ /* kept for compatibility with add-ons */
String.prototype.format = function() { String.prototype.format = function() {
let args = arguments; const args = arguments;
return this.replace(/\{\d+\}/g, function(m) { return this.replace(/\{\d+\}/g, function(m) {
return args[m.match(/\d+/)]; return args[m.match(/\d+/)];
}); });
@ -193,7 +193,7 @@ function focusPrevious() {
} }
function onDragOver(elem) { function onDragOver(elem) {
let e = (window.event as unknown) as DragOverEvent; const e = (window.event as unknown) as DragOverEvent;
//e.dataTransfer.dropEffect = "copy"; //e.dataTransfer.dropEffect = "copy";
e.preventDefault(); e.preventDefault();
// if we focus the target element immediately, the drag&drop turns into a // if we focus the target element immediately, the drag&drop turns into a
@ -214,10 +214,10 @@ function onPaste(elem) {
} }
function caretToEnd() { function caretToEnd() {
let r = document.createRange(); const r = document.createRange();
r.selectNodeContents(currentField); r.selectNodeContents(currentField);
r.collapse(false); r.collapse(false);
let s = document.getSelection(); const s = document.getSelection();
s.removeAllRanges(); s.removeAllRanges();
s.addRange(r); s.addRange(r);
} }
@ -299,10 +299,10 @@ function wrapInternal(front, back, plainText) {
front = "‫" + front + "‬"; front = "‫" + front + "‬";
back = "‫" + back + "‬"; back = "‫" + back + "‬";
} }
let s = window.getSelection(); const s = window.getSelection();
let r = s.getRangeAt(0); let r = s.getRangeAt(0);
let content = r.cloneContents(); const content = r.cloneContents();
let span = document.createElement("span"); const span = document.createElement("span");
span.appendChild(content); span.appendChild(content);
if (plainText) { if (plainText) {
const new_ = wrappedExceptForWhitespace(span.innerText, front, back); const new_ = wrappedExceptForWhitespace(span.innerText, front, back);
@ -329,7 +329,7 @@ function onCutOrCopy() {
function setFields(fields) { function setFields(fields) {
let txt = ""; let txt = "";
for (let i = 0; i < fields.length; i++) { for (let i = 0; i < fields.length; i++) {
let n = fields[i][0]; const n = fields[i][0];
let f = fields[i][1]; let f = fields[i][1];
if (!f) { if (!f) {
f = "<br>"; f = "<br>";
@ -359,7 +359,7 @@ function setBackgrounds(cols) {
function setFonts(fonts) { function setFonts(fonts) {
for (let i = 0; i < fonts.length; i++) { for (let i = 0; i < fonts.length; i++) {
let n = $("#f" + i); const n = $("#f" + i);
n.css("font-family", fonts[i][0]).css("font-size", fonts[i][1]); n.css("font-family", fonts[i][0]).css("font-size", fonts[i][1]);
n[0].dir = fonts[i][2] ? "rtl" : "ltr"; n[0].dir = fonts[i][2] ? "rtl" : "ltr";
} }
@ -377,7 +377,7 @@ function hideDupes() {
$("#dupes").hide(); $("#dupes").hide();
} }
const pasteHTML = function(html, internal, extendedMode) { let pasteHTML = function(html, internal, extendedMode) {
html = filterHTML(html, internal, extendedMode); html = filterHTML(html, internal, extendedMode);
if (html !== "") { if (html !== "") {
// remove trailing <br> in empty field // remove trailing <br> in empty field
@ -388,7 +388,7 @@ const pasteHTML = function(html, internal, extendedMode) {
} }
}; };
const filterHTML = function(html, internal, extendedMode) { let filterHTML = function(html, internal, extendedMode) {
// wrap it in <top> as we aren't allowed to change top level elements // wrap it in <top> as we aren't allowed to change top level elements
const top = $.parseHTML("<ankitop>" + html + "</ankitop>")[0] as Element; const top = $.parseHTML("<ankitop>" + html + "</ankitop>")[0] as Element;
if (internal) { if (internal) {
@ -456,7 +456,7 @@ const allowedStyling = {
"text-decoration-line": true, "text-decoration-line": true,
}; };
const filterExternalSpan = function(node) { let filterExternalSpan = function(node) {
// filter out attributes // filter out attributes
let toRemove = []; let toRemove = [];
for (const attr of node.attributes) { for (const attr of node.attributes) {
@ -490,7 +490,7 @@ allowedTagsExtended["SPAN"] = filterExternalSpan;
Object.assign(allowedTagsExtended, allowedTagsBasic); Object.assign(allowedTagsExtended, allowedTagsBasic);
// filtering from another field // filtering from another field
const filterInternalNode = function(node) { let filterInternalNode = function(node) {
if (node.style) { if (node.style) {
node.style.removeProperty("background-color"); node.style.removeProperty("background-color");
node.style.removeProperty("font-size"); node.style.removeProperty("font-size");
@ -503,7 +503,7 @@ const filterInternalNode = function(node) {
}; };
// filtering from external sources // filtering from external sources
const filterNode = function(node, extendedMode) { let filterNode = function(node, extendedMode) {
// text node? // text node?
if (node.nodeType === 3) { if (node.nodeType === 3) {
return; return;
@ -512,7 +512,7 @@ const filterNode = function(node, extendedMode) {
// descend first, and take a copy of the child nodes as the loop will skip // descend first, and take a copy of the child nodes as the loop will skip
// elements due to node modifications otherwise // elements due to node modifications otherwise
let nodes = []; const nodes = [];
for (const child of node.childNodes) { for (const child of node.childNodes) {
nodes.push(child); nodes.push(child);
} }
@ -542,7 +542,7 @@ const filterNode = function(node, extendedMode) {
tag(node); tag(node);
} else { } else {
// allowed, filter out attributes // allowed, filter out attributes
let toRemove = []; const toRemove = [];
for (const attr of node.attributes) { for (const attr of node.attributes) {
const attrName = attr.name.toUpperCase(); const attrName = attr.name.toUpperCase();
if (tag.attrs.indexOf(attrName) === -1) { if (tag.attrs.indexOf(attrName) === -1) {
@ -556,7 +556,7 @@ const filterNode = function(node, extendedMode) {
} }
}; };
const adjustFieldsTopMargin = function() { let adjustFieldsTopMargin = function() {
const topHeight = $("#topbuts").height(); const topHeight = $("#topbuts").height();
const margin = topHeight + 8; const margin = topHeight + 8;
document.getElementById("fields").style.marginTop = margin + "px"; document.getElementById("fields").style.marginTop = margin + "px";
@ -574,7 +574,7 @@ $(function() {
}; };
document.onclick = function(evt: MouseEvent) { document.onclick = function(evt: MouseEvent) {
let src = evt.target as Element; const src = evt.target as Element;
if (src.tagName === "IMG") { if (src.tagName === "IMG") {
// image clicked; find contenteditable parent // image clicked; find contenteditable parent
let p = src; let p = src;