GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 14:02:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Treat play_file() and co as internal routines without protection (#4059)

Browse source 
* Treat play_file() and co as internal routines without protection

Our code and add-ons need a way to play audio from arbitrary locations. I propose we treat the _tag API as suitable for user input, and the _file API for internal use.

* Mention basename in the *_file() paths

(cherry picked from commit 50b7588231)
This commit is contained in:
Damien Elmes 2025-06-06 12:55:04 +07:00 committed by Damien Elmes
parent 98253c81cb
commit 1b882285a5
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
qt/aqt/sound.py
View file

@ -175,14 +175,26 @@ class AVPlayer:
self._stop_if_playing() self._stop_if_playing()
def play_file(self, filename: str) -> None: def play_file(self, filename: str) -> None:
self.play_tags([SoundOrVideoTag(filename=os.path.basename(filename))]) """Play the provided path.
SECURITY: Filename may be an arbitrary path. For filenames coming from a collection,
you should only ever use the os.path.basename(filename) as the filename."""
self.play_tags([SoundOrVideoTag(filename=filename)])
def play_file_with_caller(self, filename: str, caller: Any) -> None: def play_file_with_caller(self, filename: str, caller: Any) -> None:
"""Play the provided path, noting down the caller.
SECURITY: Filename may be an arbitrary path. For filenames coming from a collection,
you should only ever use the os.path.basename(filename) as the filename."""
self.current_caller = caller self.current_caller = caller
self.play_file(filename) self.play_file(filename)
def insert_file(self, filename: str) -> None: def insert_file(self, filename: str) -> None:
self._enqueued.insert(0, SoundOrVideoTag(filename=os.path.basename(filename))) """Place the provided path at the top of the playlist.
SECURITY: Filename may be an arbitrary path. For filenames coming from a collection,
you should only ever use the os.path.basename(filename) as the filename."""
self._enqueued.insert(0, SoundOrVideoTag(filename=filename))
self._play_next_if_idle() self._play_next_if_idle()
def toggle_pause(self) -> None: def toggle_pause(self) -> None: