From 1df93b02f8c38680bf6c0885a7a33ce91314036b Mon Sep 17 00:00:00 2001
From: llama <gh@siid.sh>
Date: Wed, 10 Sep 2025 20:58:38 +0800
Subject: [PATCH] save colours on `change` instead of `input`

`input` is supposed to be fired on every adjustment to the picker
whereas `change` is only fired when the picker is accepted, but qt
seems to treat both as the latter, so this is currently a no-op
---
 ts/editor/editor-toolbar/HighlightColorButton.svelte | 4 +++-
 ts/editor/editor-toolbar/TextColorButton.svelte      | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ts/editor/editor-toolbar/HighlightColorButton.svelte b/ts/editor/editor-toolbar/HighlightColorButton.svelte
index 257f41aa5..f89f7a99a 100644
--- a/ts/editor/editor-toolbar/HighlightColorButton.svelte
+++ b/ts/editor/editor-toolbar/HighlightColorButton.svelte
@@ -134,9 +134,11 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             on:input={(event) => {
                 color = setColor(event);
                 bridgeCommand(`lastHighlightColor:${color}`);
+            }}
+            on:change={() => {
+                setTextColor();
                 saveCustomColours({});
             }}
-            on:change={() => setTextColor()}
         />
     </IconButton>
 </WithColorHelper>
diff --git a/ts/editor/editor-toolbar/TextColorButton.svelte b/ts/editor/editor-toolbar/TextColorButton.svelte
index 88d5e49f4..ce80aae49 100644
--- a/ts/editor/editor-toolbar/TextColorButton.svelte
+++ b/ts/editor/editor-toolbar/TextColorButton.svelte
@@ -153,13 +153,13 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             on:input={(event) => {
                 color = setColor(event);
                 bridgeCommand(`lastTextColor:${color}`);
-                saveCustomColours({});
             }}
             on:change={() => {
                 // Delay added to work around intermittent failures on macOS/Qt6.5
                 setTimeout(() => {
                     setTextColor();
                 }, 200);
+                saveCustomColours({});
             }}
         />
     </IconButton>