From 1fe98f2514f66143fe667f9620dc809bbec98dc5 Mon Sep 17 00:00:00 2001 From: Luc Mcgrady Date: Mon, 2 Jun 2025 13:13:59 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: user1823 <92206575+user1823@users.noreply.github.com> --- rslib/src/scheduler/fsrs/params.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rslib/src/scheduler/fsrs/params.rs b/rslib/src/scheduler/fsrs/params.rs index b316b4313..93ebd9ee0 100644 --- a/rslib/src/scheduler/fsrs/params.rs +++ b/rslib/src/scheduler/fsrs/params.rs @@ -119,8 +119,8 @@ impl Collection { }; let mut params = fsrs.compute_parameters(input.clone())?; progress_thread.join().ok(); - if let Ok(fsrs) = FSRS::new(Some(current_params)) { - let current_log_loss = fsrs.evaluate(items.clone(), |_| true)?.log_loss; + if let Ok(current_fsrs) = FSRS::new(Some(current_params)) { + let current_log_loss = current_fsrs.evaluate(items.clone(), |_| true)?.log_loss; let optimized_fsrs = FSRS::new(Some(¶ms))?; let optimized_log_loss = optimized_fsrs.evaluate(items.clone(), |_| true)?.log_loss; if current_log_loss <= optimized_log_loss {