GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-23 16:26:40 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Explicitly close the importer file descriptor

Browse source 
https://github.com/ankitects/anki/pull 613
This commit is contained in:
evandrocoan 2020-05-12 11:15:01 -03:00
parent efb62b9528
commit 200bad3714
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pylib/anki/importing/noteimp.py
View file

@ -107,6 +107,10 @@ class NoteImporter(Importer):
"Open file and ensure it's in the right format." "Open file and ensure it's in the right format."
return return
def close(self) -> None:
"Closes the open file."
return
def importNotes(self, notes: List[ForeignNote]) -> None: def importNotes(self, notes: List[ForeignNote]) -> None:
"Convert each card into a note, apply attributes and add to col." "Convert each card into a note, apply attributes and add to col."
assert self.mappingOk() assert self.mappingOk()

3
qt/aqt/importing.py
View file

@ -361,6 +361,7 @@ def importFile(mw, file):
mw.progress.start(immediate=True) mw.progress.start(immediate=True)
try: try:
importer.open() importer.open()
diag = ImportDialog(mw, importer)
except UnicodeDecodeError: except UnicodeDecodeError:
mw.progress.finish() mw.progress.finish()
showUnicodeWarning() showUnicodeWarning()
@ -377,7 +378,7 @@ def importFile(mw, file):
return return
finally: finally:
mw.progress.finish() mw.progress.finish()
diag = ImportDialog(mw, importer) importer.close()
else: else:
# if it's an apkg/zip, first test it's a valid file # if it's an apkg/zip, first test it's a valid file
if importer.__class__.__name__ == "AnkiPackageImporter": if importer.__class__.__name__ == "AnkiPackageImporter":