From 20813eeb32dc8cc16785319c3c0f4f326a3a7ecf Mon Sep 17 00:00:00 2001 From: Aristotelis <5459332+glutanimate@users.noreply.github.com> Date: Sat, 28 Oct 2023 05:18:21 +0200 Subject: [PATCH] Always set an AnkiWebViewKind (#2782) --- qt/aqt/webview.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qt/aqt/webview.py b/qt/aqt/webview.py index 9f100ac3f..7bc302985 100644 --- a/qt/aqt/webview.py +++ b/qt/aqt/webview.py @@ -233,6 +233,7 @@ class AnkiWebViewKind(Enum): When introducing a new web view, please add it to the registry below. """ + DEFAULT = "default" MAIN = "main webview" TOP_TOOLBAR = "top toolbar" BOTTOM_TOOLBAR = "bottom toolbar" @@ -254,18 +255,17 @@ class AnkiWebViewKind(Enum): class AnkiWebView(QWebEngineView): allow_drops = False - _kind: AnkiWebViewKind | None + _kind: AnkiWebViewKind def __init__( self, parent: QWidget | None = None, - title: str = "default", - kind: AnkiWebViewKind | None = None, + title: str = "", # used by add-ons; in Anki code use kind instead to set title + kind: AnkiWebViewKind = AnkiWebViewKind.DEFAULT, ) -> None: QWebEngineView.__init__(self, parent=parent) - if kind: - self.set_kind(kind) - else: + self.set_kind(kind) + if title: self.set_title(title) self._page = AnkiWebPage(self._onBridgeCmd) # reduce flicker @@ -303,7 +303,7 @@ class AnkiWebView(QWebEngineView): self.set_title(kind.value) @property - def kind(self) -> AnkiWebViewKind | None: + def kind(self) -> AnkiWebViewKind: """Used by add-ons to identify the webview kind""" return self._kind