From 220e14bf0fe0fba1339ba4a226fd8162cec5147a Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Sat, 8 May 2021 12:15:49 +1000 Subject: [PATCH] disable broken svelte_check test on Windows for now Likely caused by a lack of sandboxing on Windows, causing the generated .d.ts files to be visible to svelte_check, and being picked up in preference over the .svelte file. --- ts/editor/BUILD.bazel | 5 +++++ ts/svelte/svelte.bzl | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ts/editor/BUILD.bazel b/ts/editor/BUILD.bazel index 823918080..b3e440e53 100644 --- a/ts/editor/BUILD.bazel +++ b/ts/editor/BUILD.bazel @@ -176,4 +176,9 @@ svelte_check( "//ts/components:svelte_components", "@npm//@types/bootstrap", ], + target_compatible_with = select({ + "@platforms//os:osx": [], + "@platforms//os:linux": [], + "//conditions:default": ["@platforms//os:linux"], + }), ) diff --git a/ts/svelte/svelte.bzl b/ts/svelte/svelte.bzl index 149447286..61dc14994 100644 --- a/ts/svelte/svelte.bzl +++ b/ts/svelte/svelte.bzl @@ -78,7 +78,7 @@ def compile_svelte(name, srcs, deps = [], visibility = ["//visibility:private"]) visibility = visibility, ) -def svelte_check(name = "svelte_check", srcs = []): +def svelte_check(name = "svelte_check", srcs = [], target_compatible_with = []): _svelte_check( name = name, args = [ @@ -95,4 +95,5 @@ def svelte_check(name = "svelte_check", srcs = []): "@npm//sass", ] + srcs, env = {"SASS_PATH": "$(rootpath //ts:tsconfig.json)/../.."}, + target_compatible_with = target_compatible_with, )