GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-23 00:12:25 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

drop pytype from CI checks

Browse source 
less useful as more type hints are added
This commit is contained in:
Damien Elmes 2019-12-23 08:40:37 +10:00
parent f7ae4c3ef4
commit 30f5a82d35
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/pythonpackage.yml vendored
View file

@ -26,5 +26,5 @@ jobs:
pip install -r requirements.qt pip install -r requirements.qt
- name: Run checks - name: Run checks
run: | run: |
make check pytype make check

7
README.contributing
View file

@ -54,12 +54,11 @@ but not very good at type inference, so it is mostly useful for checking code
that has type signatures. It is able to read the bundled Qt stubs, and works that has type signatures. It is able to read the bundled Qt stubs, and works
across the whole Anki codebase. across the whole Anki codebase.
When you use 'make pytype', Anki will typecheck the code with pytype. Pytype You can optionally use 'make pytype' to typecheck the code with pytype. Pytype
is much slower, but it can catch errors in untyped code that mypy misses. It is much slower, but it can catch errors in untyped code that mypy misses. It
is not able to check the aqt/* code, as it can't read the Qt stubs, and it is is not able to check the aqt/* code, as it can't read the Qt stubs, and it is
not currently compatible with Python 3.8. It can also be difficult to build, not currently compatible with Python 3.8. It can be difficult to build on
so it is not included in the default 'make check', but it will be run when a some platforms.
pull request is submitted.
The Qt stubs are not perfect, so you'll find when doing things like connecting The Qt stubs are not perfect, so you'll find when doing things like connecting
signals, you may have to add the following to the end of a line to silence signals, you may have to add the following to the end of a line to silence