From 341f9ae1f4319d990d7202953a4a1bc66412620d Mon Sep 17 00:00:00 2001
From: Jarrett Ye <jarrett.ye@outlook.com>
Date: Fri, 11 Jul 2025 14:20:06 +0800
Subject: [PATCH] Refactor desired retention handling in FsrsOptions.svelte

Updated the logic for effective desired retention to use the configuration default instead of the deck-specific value. This change improves consistency in the retention value used throughout the component, ensuring that the correct value is bound to the UI elements.
---
 ts/routes/deck-options/FsrsOptions.svelte | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/ts/routes/deck-options/FsrsOptions.svelte b/ts/routes/deck-options/FsrsOptions.svelte
index b3b55c8db..9b7bb218e 100644
--- a/ts/routes/deck-options/FsrsOptions.svelte
+++ b/ts/routes/deck-options/FsrsOptions.svelte
@@ -106,15 +106,14 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         ),
     ];
 
-    let desiredRetentionValue = $config.desiredRetention;
-
     // Get the effective desired retention value (deck-specific if set, otherwise config default)
-    $: effectiveDesiredRetention = $limits.desiredRetention ?? $config.desiredRetention;
+    let effectiveDesiredRetention =
+        $limits.desiredRetention ?? $config.desiredRetention;
     const startingDesiredRetention = effectiveDesiredRetention.toFixed(2);
 
     $: simulateFsrsRequest = new SimulateFsrsReviewRequest({
         params: fsrsParams($config),
-        desiredRetention: effectiveDesiredRetention,
+        desiredRetention: $config.desiredRetention,
         newLimit: $config.newPerDay,
         reviewLimit: $config.reviewsPerDay,
         maxInterval: $config.maximumReviewInterval,
@@ -331,7 +330,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 <DynamicallySlottable slotHost={Item} api={{}}>
     <Item>
         <SpinBoxFloatRow
-            bind:value={desiredRetentionValue}
+            bind:value={effectiveDesiredRetention}
             defaultValue={defaults.desiredRetention}
             min={0.7}
             max={0.99}
@@ -341,7 +340,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             <TabbedValue
                 slot="tabs"
                 tabs={desiredRetentionTabs}
-                bind:value={desiredRetentionValue}
+                bind:value={effectiveDesiredRetention}
             />
             <SettingTitle on:click={() => openHelpModal("desiredRetention")}>
                 {tr.deckConfigDesiredRetention()}