From 37ba8832f839e1e186faa97eb6880b833bf8a82c Mon Sep 17 00:00:00 2001
From: dequis <dx@dxzone.com.ar>
Date: Sun, 16 Jul 2017 23:25:34 -0300
Subject: [PATCH] Make hooks.wrap preserve signatures, fixes hooking some pyqt5
 callbacks

It looks like pyqt5 is playing dirty and checking the number of args of
functions before calling them. When using hooks.wrap, pyqt5 thinks it
can pass any amount of arguments (because *args) and you get exceptions
like this inside the wrap function, when calling the 'old' function:

>TypeError: onFindDupes() takes 1 positional argument but 2 were given

This commit fixes it by preserving the signature of the wrapped method,
by adding an optional dependency on the "decorator" module.

Making it an optional dependency is probably not the wisest idea but
since this is a small edge case it might be smoother to start like this.

I also added functools.wraps() as a fallback, which won't help much but
is slightly more correct.

See this article for details: https://hynek.me/articles/decorators/
---
 anki/hooks.py    | 17 ++++++++++++++++-
 requirements.txt |  1 +
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/anki/hooks.py b/anki/hooks.py
index 7c5270bce..f29e75003 100644
--- a/anki/hooks.py
+++ b/anki/hooks.py
@@ -13,6 +13,14 @@ If you call wrap() with pos='around', the original function will not be called
 automatically but can be called with _old().
 """
 
+import functools
+
+try:
+    # optional: like functools.wraps, but signature-preserving
+    import decorator
+except ImportError:
+    decorator = None
+
 # Hooks
 ##############################################################################
 
@@ -59,4 +67,11 @@ def wrap(old, new, pos="after"):
             return old(*args, **kwargs)
         else:
             return new(_old=old, *args, **kwargs)
-    return repl
+
+    if decorator is None:
+        return functools.wraps(repl)
+
+    def decorator_wrapper(f, *args, **kwargs):
+        return repl(*args, **kwargs)
+
+    return decorator.decorator(decorator_wrapper)(old)
diff --git a/requirements.txt b/requirements.txt
index cd37c7b9e..ba519212a 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -3,3 +3,4 @@ send2trash
 httplib2
 pyaudio
 requests
+decorator