From 37ed3e8209e0065e4de784bcf6214602fabe7706 Mon Sep 17 00:00:00 2001
From: Henrik Giesel <hengiesel@gmail.com>
Date: Thu, 1 Apr 2021 18:55:34 +0200
Subject: [PATCH] Fix some code quality issues

---
 qt/aqt/data/web/imgs/vendor/BUILD.bazel    | 19 -------------------
 ts/editor-toolbar/ColorPicker.svelte       |  2 +-
 ts/editor-toolbar/CommandIconButton.svelte |  4 ++--
 ts/editor-toolbar/DropdownItem.svelte      |  2 +-
 ts/editor-toolbar/EditorToolbar.svelte     |  1 +
 ts/editor-toolbar/IconButton.svelte        |  2 +-
 ts/editor-toolbar/LabelButton.svelte       |  2 +-
 ts/editor-toolbar/SelectButton.svelte      |  3 +--
 ts/editor-toolbar/SquareButton.svelte      |  2 +-
 ts/editor-toolbar/WithDropdownMenu.svelte  |  2 --
 ts/editor-toolbar/contextKeys.ts           |  4 ++--
 11 files changed, 11 insertions(+), 32 deletions(-)
 delete mode 100644 qt/aqt/data/web/imgs/vendor/BUILD.bazel

diff --git a/qt/aqt/data/web/imgs/vendor/BUILD.bazel b/qt/aqt/data/web/imgs/vendor/BUILD.bazel
deleted file mode 100644
index f316948a7..000000000
--- a/qt/aqt/data/web/imgs/vendor/BUILD.bazel
+++ /dev/null
@@ -1,19 +0,0 @@
-load("//ts:vendor.bzl", "copy_bootstrap_icons", "copy_fontawesome_icons")
-
-copy_bootstrap_icons(name = "bootstrap-icons")
-
-copy_fontawesome_icons(name = "fontawesome-icons")
-
-files = [
-    "bootstrap-icons",
-    "fontawesome-icons",
-]
-
-directories = []
-
-filegroup(
-    name = "vendor",
-    srcs = ["//qt/aqt/data/web/imgs/vendor:{}".format(file) for file in files] +
-           ["//qt/aqt/data/web/imgs/vendor/{}".format(dir) for dir in directories],
-    visibility = ["//qt:__subpackages__"],
-)
diff --git a/ts/editor-toolbar/ColorPicker.svelte b/ts/editor-toolbar/ColorPicker.svelte
index b9450d617..da979a0a2 100644
--- a/ts/editor-toolbar/ColorPicker.svelte
+++ b/ts/editor-toolbar/ColorPicker.svelte
@@ -4,7 +4,7 @@
     export let props: Record<string, string> = {};
     export let title: string;
 
-    export let onChange: (event: ChangeEvent) => void;
+    export let onChange: (event: Event) => void;
 </script>
 
 <style lang="scss">
diff --git a/ts/editor-toolbar/CommandIconButton.svelte b/ts/editor-toolbar/CommandIconButton.svelte
index 6d098fd97..ed45d23cc 100644
--- a/ts/editor-toolbar/CommandIconButton.svelte
+++ b/ts/editor-toolbar/CommandIconButton.svelte
@@ -50,13 +50,13 @@
     if (activatable) {
         initializeButton(command);
 
-        commandMap.subscribe((map: Record<string, boolean>): void => {
+        commandMap.subscribe((map: Map<string, boolean>): void => {
             active = map.get(command);
             return () => map.delete(command);
         });
     }
 
-    function onClick(event: ClickEvent): void {
+    function onClick(): void {
         document.execCommand(command);
     }
 </script>
diff --git a/ts/editor-toolbar/DropdownItem.svelte b/ts/editor-toolbar/DropdownItem.svelte
index cd8e971a9..1be8dbe25 100644
--- a/ts/editor-toolbar/DropdownItem.svelte
+++ b/ts/editor-toolbar/DropdownItem.svelte
@@ -4,7 +4,7 @@
     export let props: Record<string, string> = {};
     export let title: string;
 
-    export let onClick: (event: ClickEvent) => void;
+    export let onClick: (event: MouseEvent) => void;
     export let label: string;
     export let endLabel: string;
 </script>
diff --git a/ts/editor-toolbar/EditorToolbar.svelte b/ts/editor-toolbar/EditorToolbar.svelte
index f6c5ac687..3ff55c944 100644
--- a/ts/editor-toolbar/EditorToolbar.svelte
+++ b/ts/editor-toolbar/EditorToolbar.svelte
@@ -1,4 +1,5 @@
 <script lang="typescript">
+    import type { SvelteComponent } from "svelte";
     import type { Readable } from "svelte/store";
     import { setContext } from "svelte";
     import { disabledKey, nightModeKey } from "./contextKeys";
diff --git a/ts/editor-toolbar/IconButton.svelte b/ts/editor-toolbar/IconButton.svelte
index c75562c64..0e9745e72 100644
--- a/ts/editor-toolbar/IconButton.svelte
+++ b/ts/editor-toolbar/IconButton.svelte
@@ -7,7 +7,7 @@
     export let title: string;
 
     export let icon = "";
-    export let onClick: (event: ClickEvent) => void;
+    export let onClick: (event: MouseEvent) => void;
 </script>
 
 <SquareButton {id} {className} {props} {title} {onClick} on:mount>
diff --git a/ts/editor-toolbar/LabelButton.svelte b/ts/editor-toolbar/LabelButton.svelte
index c83f4ce16..583a0190b 100644
--- a/ts/editor-toolbar/LabelButton.svelte
+++ b/ts/editor-toolbar/LabelButton.svelte
@@ -8,7 +8,7 @@
 
     export let label: string;
     export let title: string;
-    export let onClick: (event: ClickEvent) => void;
+    export let onClick: (event: MouseEvent) => void;
     export let disables = true;
 
     let buttonRef: HTMLButtonElement;
diff --git a/ts/editor-toolbar/SelectButton.svelte b/ts/editor-toolbar/SelectButton.svelte
index 825b8ff3f..13da0b04c 100644
--- a/ts/editor-toolbar/SelectButton.svelte
+++ b/ts/editor-toolbar/SelectButton.svelte
@@ -1,6 +1,5 @@
 <script lang="typescript">
     import { onMount, createEventDispatcher, getContext } from "svelte";
-    import type { Readable } from "svelte/store";
     import { disabledKey } from "./contextKeys";
     import SelectOption from "./SelectOption.svelte";
 
@@ -19,7 +18,7 @@
         return `form-select ${classes}`;
     }
 
-    export let disables;
+    export let disables = true;
     export let options: Option[];
 
     let buttonRef: HTMLSelectElement;
diff --git a/ts/editor-toolbar/SquareButton.svelte b/ts/editor-toolbar/SquareButton.svelte
index ad963ec2a..5f57808a6 100644
--- a/ts/editor-toolbar/SquareButton.svelte
+++ b/ts/editor-toolbar/SquareButton.svelte
@@ -8,7 +8,7 @@
     export let props: Record<string, string> = {};
     export let title: string;
 
-    export let onClick: (event: ClickEvent) => void;
+    export let onClick: (event: MouseEvent) => void;
     export let active = false;
 
     let buttonRef: HTMLButtonElement;
diff --git a/ts/editor-toolbar/WithDropdownMenu.svelte b/ts/editor-toolbar/WithDropdownMenu.svelte
index 582afd125..3ae27f060 100644
--- a/ts/editor-toolbar/WithDropdownMenu.svelte
+++ b/ts/editor-toolbar/WithDropdownMenu.svelte
@@ -1,6 +1,4 @@
 <script lang="typescript">
-    import { onMount } from "svelte";
-
     import type { ButtonDefinition } from "./types";
 
     export let button: ButtonDefinition;
diff --git a/ts/editor-toolbar/contextKeys.ts b/ts/editor-toolbar/contextKeys.ts
index 05fd7e0bd..09ef3bbc3 100644
--- a/ts/editor-toolbar/contextKeys.ts
+++ b/ts/editor-toolbar/contextKeys.ts
@@ -1,2 +1,2 @@
-export let nightModeKey = Symbol("nightMode");
-export let disabledKey = Symbol("disabled");
+export const nightModeKey = Symbol("nightMode");
+export const disabledKey = Symbol("disabled");