From 38c7e501e0d1a31c9769cc649803bb574b449d45 Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Wed, 22 Sep 2021 21:45:14 +1000 Subject: [PATCH] Merge pull request #1384 from hikaru-y/fix-previewer-memory-leak Fix memory leak in previewer (cherry picked from commit 1cd911ab637e6408df4199f80b024f1171ca503c) --- qt/aqt/browser/previewer.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qt/aqt/browser/previewer.py b/qt/aqt/browser/previewer.py index b9a25f7d2..b325655ae 100644 --- a/qt/aqt/browser/previewer.py +++ b/qt/aqt/browser/previewer.py @@ -47,6 +47,7 @@ class Previewer(QDialog): self, parent: QWidget, mw: AnkiQt, on_close: Callable[[], None] ) -> None: super().__init__(None, Qt.Window) + mw.garbage_collect_on_dialog_finish(self) self._open = True self._parent = parent self._close_callback = on_close @@ -123,6 +124,7 @@ class Previewer(QDialog): def _on_close(self) -> None: self._open = False self._close_callback() + self._web = None def _setup_web_view(self) -> None: self._web.stdHtml(