From 3bf0b253f2cac5edeb2bac0a10372fda9b61a4b0 Mon Sep 17 00:00:00 2001
From: Damien Elmes <git@ichi2.net>
Date: Sun, 30 Oct 2011 10:12:24 +0900
Subject: [PATCH] handle bad field references and tags; don't create empty
 fields

---
 anki/upgrade.py | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/anki/upgrade.py b/anki/upgrade.py
index 197b303c7..893aa1948 100644
--- a/anki/upgrade.py
+++ b/anki/upgrade.py
@@ -431,15 +431,6 @@ order by ordinal""", mid)):
                 # we've converted this field before
                 new = state['mflds'][all]
             else:
-                # find a free field name
-                while 1:
-                    state['fields'] += 1
-                    fld = "Media %d" % state['fields']
-                    if fld not in deck.models.fieldMap(m).keys():
-                        break
-                # add the new field
-                f = deck.models.newField(fld)
-                deck.models.addField(m, f)
                 # get field name and any prefix/suffix
                 m2 = re.match(
                     "([^{]*)\{\{\{?(?:text:)?([^}]+)\}\}\}?(.*)",
@@ -449,7 +440,20 @@ order by ordinal""", mid)):
                     return
                 pre, ofld, suf = m2.groups()
                 # get index of field name
-                idx = deck.models.fieldMap(m)[ofld][0]
+                try:
+                    idx = deck.models.fieldMap(m)[ofld][0]
+                except:
+                    # invalid field or tag reference; don't rewrite
+                    return
+                # find a free field name
+                while 1:
+                    state['fields'] += 1
+                    fld = "Media %d" % state['fields']
+                    if fld not in deck.models.fieldMap(m).keys():
+                        break
+                # add the new field
+                f = deck.models.newField(fld)
+                deck.models.addField(m, f)
                 # loop through facts and write reference into new field
                 data = []
                 for id, flds in self.deck.db.execute(