From c83324bf816c716728aa828b4706f9076b019452 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanna=20Nils=C3=A9n?= Date: Wed, 10 Sep 2025 13:40:45 +0200 Subject: [PATCH 1/4] Fix: remove visible text for Retention help link --- ftl/core/help.ftl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ftl/core/help.ftl b/ftl/core/help.ftl index 80a08703e..288a88671 100644 --- a/ftl/core/help.ftl +++ b/ftl/core/help.ftl @@ -2,8 +2,8 @@ ## Header/footer -# Link to more detailed information in the manual -help-for-more-info = For more information, see { $link } in the manual. +# Field for linking to more manual details +help-for-more-info = ​ # Tooltip for links to the manual help-open-manual-chapter = Open { $name } in the manual From 2d26e675c28422752280e308e4a63ade8c458829 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanna=20Nils=C3=A9n?= Date: Wed, 10 Sep 2025 14:56:09 +0200 Subject: [PATCH 2/4] add myself to CONTRIBUTORS --- CONTRIBUTORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index b03108e16..9a9e6d042 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -242,7 +242,7 @@ Lee Doughty <32392044+leedoughty@users.noreply.github.com> memchr Max Romanowski Aldlss - +Hannanilsenn ******************** The text of the 3 clause BSD license follows: From 3ee673eb9cd3c68ce9bc2187bc09f308d214fad2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanna=20Nils=C3=A9n?= Date: Thu, 11 Sep 2025 08:51:28 +0200 Subject: [PATCH 3/4] stats: remove manual link from retention tooltip only --- CONTRIBUTORS | 1 + ts/routes/graphs/TrueRetention.svelte | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 9a9e6d042..73d6063f3 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -243,6 +243,7 @@ memchr Max Romanowski Aldlss Hannanilsenn + ******************** The text of the 3 clause BSD license follows: diff --git a/ts/routes/graphs/TrueRetention.svelte b/ts/routes/graphs/TrueRetention.svelte index 4a9738831..6fb8deccc 100644 --- a/ts/routes/graphs/TrueRetention.svelte +++ b/ts/routes/graphs/TrueRetention.svelte @@ -72,7 +72,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html > { modal = e.detail.modal; From 3929df8962cd2c08f8110f9fa7b2902dbd78784b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanna=20Nils=C3=A9n?= Date: Thu, 11 Sep 2025 14:48:13 +0200 Subject: [PATCH 4/4] Fix: restore retention help link text --- ftl/core/help.ftl | 4 ++-- ts/lib/components/HelpModal.svelte | 2 +- ts/lib/components/HelpSection.svelte | 4 +--- ts/routes/graphs/TrueRetention.svelte | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/ftl/core/help.ftl b/ftl/core/help.ftl index 288a88671..80a08703e 100644 --- a/ftl/core/help.ftl +++ b/ftl/core/help.ftl @@ -2,8 +2,8 @@ ## Header/footer -# Field for linking to more manual details -help-for-more-info = ​ +# Link to more detailed information in the manual +help-for-more-info = For more information, see { $link } in the manual. # Tooltip for links to the manual help-open-manual-chapter = Open { $name } in the manual diff --git a/ts/lib/components/HelpModal.svelte b/ts/lib/components/HelpModal.svelte index cf6292537..e8de8e353 100644 --- a/ts/lib/components/HelpModal.svelte +++ b/ts/lib/components/HelpModal.svelte @@ -22,7 +22,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html import { type HelpItem, HelpItemScheduler } from "./types"; export let title: string; - export let url: string; + export let url: string | undefined; export let startIndex = 0; export let helpSections: HelpItem[]; export let fsrs = false; diff --git a/ts/lib/components/HelpSection.svelte b/ts/lib/components/HelpSection.svelte index b52486865..19e97c982 100644 --- a/ts/lib/components/HelpSection.svelte +++ b/ts/lib/components/HelpSection.svelte @@ -42,9 +42,7 @@
{@html renderMarkdown( tr.helpForMoreInfo({ - link: `${item.title}`, + link: `${item.title}`, }), )}
diff --git a/ts/routes/graphs/TrueRetention.svelte b/ts/routes/graphs/TrueRetention.svelte index 6fb8deccc..c94b2ab12 100644 --- a/ts/routes/graphs/TrueRetention.svelte +++ b/ts/routes/graphs/TrueRetention.svelte @@ -5,7 +5,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html