GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-10 12:33:55 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Replace menu string with enum

Browse source
This commit is contained in:
Luc Mcgrady 2025-11-13 21:49:22 +00:00
parent 9f47d7beb1
commit 3dba3580a7
No known key found for this signature in database
GPG key ID: 4F3D7A0B17CC3D9C
3 changed files with 27 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
proto/anki/frontend.proto
View file

@ -54,6 +54,15 @@ message PlayAVTagsRequest {
} }
message OpenReviewerMenuRequest { message OpenReviewerMenuRequest {
string name = 1; enum ReviewerMenu {
EditCurrent = 0;
SetDueDate = 1;
CardInfo = 2;
CreateCopy = 3;
Forget = 4;
Options = 5;
};
ReviewerMenu menu = 1;
optional int64 current_card_id = 2; optional int64 current_card_id = 2;
} }

15
qt/aqt/mediasrv.py
View file

@ -708,24 +708,25 @@ def play_avtags():
def open_reviewer_menu(): def open_reviewer_menu():
reviewer = aqt.mw.reviewer reviewer = aqt.mw.reviewer
MENU_ENUM = OpenReviewerMenuRequest.ReviewerMenu
def on_card_info(): def on_card_info():
reviewer._card_info.set_card(reviewer.card) reviewer._card_info.set_card(reviewer.card)
reviewer.on_card_info() reviewer.on_card_info()
REVIEWER_MENUS = { REVIEWER_MENUS = {
"EditCurrent": aqt.mw.onEditCurrent, MENU_ENUM.EditCurrent: aqt.mw.onEditCurrent,
"SetDueDate": reviewer.on_set_due, MENU_ENUM.SetDueDate: reviewer.on_set_due,
"CardInfo": on_card_info, MENU_ENUM.CardInfo: on_card_info,
"CreateCopy": reviewer.on_create_copy, MENU_ENUM.CreateCopy: reviewer.on_create_copy,
"Forget": reviewer.forget_current_card, MENU_ENUM.Forget: reviewer.forget_current_card,
"Options": reviewer.onOptions, MENU_ENUM.Options: reviewer.onOptions,
} }
req = OpenReviewerMenuRequest.FromString(request.data) req = OpenReviewerMenuRequest.FromString(request.data)
if req.HasField("current_card_id"): if req.HasField("current_card_id"):
reviewer.card = aqt.mw.col.get_card(CardId(req.current_card_id)) reviewer.card = aqt.mw.col.get_card(CardId(req.current_card_id))
aqt.mw.taskman.run_on_main(REVIEWER_MENUS[req.name]) aqt.mw.taskman.run_on_main(REVIEWER_MENUS[req.menu])
post_handler_list = [ post_handler_list = [

17
ts/routes/reviewer/reviewer.ts
View file

@ -1,6 +1,7 @@
// Copyright: Ankitects Pty Ltd and contributors // Copyright: Ankitects Pty Ltd and contributors
// License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html // License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
import type { UndoStatus } from "@generated/anki/collection_pb"; import type { UndoStatus } from "@generated/anki/collection_pb";
import { OpenReviewerMenuRequest_ReviewerMenu } from "@generated/anki/frontend_pb";
import { import {
BuryOrSuspendCardsRequest_Mode, BuryOrSuspendCardsRequest_Mode,
CardAnswer, CardAnswer,
@ -106,32 +107,32 @@ export class ReviewerState {
this.showQuestion(null); this.showQuestion(null);
} }
displayMenu(name: string) { displayMenu(menu: OpenReviewerMenuRequest_ReviewerMenu) {
openReviewerMenu({ name, currentCardId: this.currentCard?.card?.id }); openReviewerMenu({ menu, currentCardId: this.currentCard?.card?.id });
} }
public displayEditMenu() { public displayEditMenu() {
this.displayMenu("EditCurrent"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.EditCurrent);
} }
public displaySetDueDateMenu() { public displaySetDueDateMenu() {
this.displayMenu("SetDueDate"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.SetDueDate);
} }
public displayCardInfoMenu() { public displayCardInfoMenu() {
this.displayMenu("CardInfo"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.CardInfo);
} }
public displayCreateCopyMenu() { public displayCreateCopyMenu() {
this.displayMenu("CreateCopy"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.CreateCopy);
} }
public displayForgetMenu() { public displayForgetMenu() {
this.displayMenu("Forget"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.Forget);
} }
public displayOptionsMenu() { public displayOptionsMenu() {
this.displayMenu("Options"); this.displayMenu(OpenReviewerMenuRequest_ReviewerMenu.Options);
} }
public toggleMarked() { public toggleMarked() {