From 3f3c1255bf55ae1d08179f4c798b10a783736843 Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Tue, 4 Feb 2020 17:06:50 +1000 Subject: [PATCH] clearer variable names --- qt/aqt/about.py | 39 +++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/qt/aqt/about.py b/qt/aqt/about.py index 6a1846042..2c57627da 100644 --- a/qt/aqt/about.py +++ b/qt/aqt/about.py @@ -34,35 +34,38 @@ def show(mw): # Copy debug info ###################################################################### - def addon_fmt(addmgr: AddonManager, a: AddonMeta) -> str: - if a.installed_at: - t = time.strftime("%Y-%m-%dT%H:%M", time.localtime(a.installed_at)) + + def addon_fmt(addmgr: AddonManager, addon: AddonMeta) -> str: + if addon.installed_at: + installed = time.strftime( + "%Y-%m-%dT%H:%M", time.localtime(addon.installed_at) + ) else: - t = "0" - if a.provided_name: - n = a.provided_name + installed = "0" + if addon.provided_name: + name = addon.provided_name else: - n = "''" - user = addmgr.getConfig(a.dir_name) - default = addmgr.addonConfigDefaults(a.dir_name) + name = "''" + user = addmgr.getConfig(addon.dir_name) + default = addmgr.addonConfigDefaults(addon.dir_name) if user == default: - confstat = "''" + modified = "''" else: - confstat = "mod" - return f"{n} ['{a.dir_name}', {t}, '{a.human_version}', {confstat}]" + modified = "mod" + return f"{name} ['{addon.dir_name}', {installed}, '{addon.human_version}', {modified}]" def onCopy(): addmgr = mw.addonManager active = [] activeids = [] inactive = [] - for a in addmgr.all_addon_meta(): - if a.enabled: - active.append(addon_fmt(addmgr, a)) - if a.ankiweb_id(): - activeids.append(a.dir_name) + for addon in addmgr.all_addon_meta(): + if addon.enabled: + active.append(addon_fmt(addmgr, addon)) + if addon.ankiweb_id(): + activeids.append(addon.dir_name) else: - inactive.append(addon_fmt(addmgr, a)) + inactive.append(addon_fmt(addmgr, addon)) newline = "\n" info = f""" {supportText()}