GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Ensure fuzz doesn't go backwards

Browse source 
Closes #2694
This commit is contained in:
Damien Elmes 2023-10-03 13:23:27 +10:00
parent 259ed9c34d
commit 41bddfc6cb
1 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
rslib/src/scheduler/states/review.rs
View file

@ -160,9 +160,33 @@ impl ReviewState {
ctx: &StateContext, ctx: &StateContext,
states: &NextStates, states: &NextStates,
) -> (u32, u32, u32) { ) -> (u32, u32, u32) {
let hard = constrain_passing_interval(ctx, states.hard.interval as f32, 1, true); // If the interval is larger than last time, don't allow fuzz to go backwards
let good = constrain_passing_interval(ctx, states.good.interval as f32, hard + 1, true); let greater_than_last = |interval: u32| {
let easy = constrain_passing_interval(ctx, states.easy.interval as f32, good + 1, true); if interval > self.scheduled_days {
self.scheduled_days + 1
} else {
// User may have changed their retention factor; don't limit
0
}
};
let hard = constrain_passing_interval(
ctx,
states.hard.interval as f32,
greater_than_last(states.hard.interval).max(1),
true,
);
let good = constrain_passing_interval(
ctx,
states.good.interval as f32,
greater_than_last(states.good.interval).max(hard + 1),
true,
);
let easy = constrain_passing_interval(
ctx,
states.easy.interval as f32,
greater_than_last(states.easy.interval).max(good + 1),
true,
);
(hard, good, easy) (hard, good, easy)
} }