From 4c699894799b151d7d7c6dd3e96943e2c336fbd7 Mon Sep 17 00:00:00 2001
From: Jarrett Ye <jarrett.ye@outlook.com>
Date: Wed, 30 Jul 2025 15:17:49 +0800
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Luc Mcgrady <lucmcgrady@gmail.com>
---
 rslib/src/revlog/mod.rs                  | 2 +-
 rslib/src/scheduler/fsrs/memory_state.rs | 2 +-
 rslib/src/stats/graphs/retention.rs      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rslib/src/revlog/mod.rs b/rslib/src/revlog/mod.rs
index 7a187ae95..2155bfcdc 100644
--- a/rslib/src/revlog/mod.rs
+++ b/rslib/src/revlog/mod.rs
@@ -88,7 +88,7 @@ impl RevlogEntry {
     /// Returns true if the review entry is not manually rescheduled and not
     /// cramming. Used to filter out entries that shouldn't be considered
     /// for statistics and scheduling.
-    pub(crate) fn has_rating_and_affect_scheduling(&self) -> bool {
+    pub(crate) fn has_rating_and_affects_scheduling(&self) -> bool {
         // not rescheduled/set due date/reset
         self.button_chosen > 0
             // not cramming
diff --git a/rslib/src/scheduler/fsrs/memory_state.rs b/rslib/src/scheduler/fsrs/memory_state.rs
index b9d718994..65253bfc3 100644
--- a/rslib/src/scheduler/fsrs/memory_state.rs
+++ b/rslib/src/scheduler/fsrs/memory_state.rs
@@ -323,7 +323,7 @@ pub(crate) fn get_last_revlog_info(revlogs: &[RevlogEntry]) -> HashMap<CardId, L
         .for_each(|(card_id, group)| {
             let mut last_reviewed_at = None;
             for e in group.into_iter() {
-                if e.has_rating_and_affect_scheduling() {
+                if e.has_rating_and_affects_scheduling() {
                     last_reviewed_at = Some(e.id.as_secs());
                 }
             }
diff --git a/rslib/src/stats/graphs/retention.rs b/rslib/src/stats/graphs/retention.rs
index 204733fe5..231a892f0 100644
--- a/rslib/src/stats/graphs/retention.rs
+++ b/rslib/src/stats/graphs/retention.rs
@@ -53,7 +53,7 @@ impl GraphsContext {
         self.revlog
             .iter()
             .filter(|review| {
-                review.has_rating_and_affect_scheduling()
+                review.has_rating_and_affects_scheduling()
                     // cards with an interval ≥ 1 day
                     && (review.review_kind == RevlogReviewKind::Review
                         || review.last_interval <= -86400