From 5296bf0a0070d4289a99d9398cac367bd41e5485 Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Wed, 18 Aug 2021 16:25:23 +1000 Subject: [PATCH] shift timebox check to post-answer - should prevent non-review actions from triggering display - should prevent next card's audio from playing before diag. dismissed - the timer hack should no longer be required, as the webview will have already been loaded https://forums.ankiweb.net/t/timebox-pop-up-suddenly-appears-when-daily-cutoff-hour-rolls-over-even-when-not-in-the-reviewer/12385 --- qt/aqt/reviewer.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/qt/aqt/reviewer.py b/qt/aqt/reviewer.py index b0a14143e..45e7f6c0b 100644 --- a/qt/aqt/reviewer.py +++ b/qt/aqt/reviewer.py @@ -208,11 +208,6 @@ class Reviewer: self._showQuestion() - # Qt seems to get stuck if the timebox modal gets invoked when the - # webview is being loaded - # https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/96 - self.mw.progress.timer(10, self.check_timebox, False) - def _get_next_v1_v2_card(self) -> None: if self.cardQueue: # undone/edited cards to show @@ -429,7 +424,8 @@ class Reviewer: gui_hooks.reviewer_did_answer_card(self, self.card, ease) self._answeredIds.append(self.card.id) self.mw.autosave() - self.nextCard() + if not self.check_timebox(): + self.nextCard() # Handlers ############################################################