From 5462d99255c41ed47b7953ca6487594ba7cabd5d Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 8 Aug 2025 08:56:50 +0100
Subject: [PATCH] Fix/Retention help button bounds (#4253)

* Move onTitleClick

* rename variable

* Fix: Tabbing issues
---
 ts/lib/components/TitledContainer.svelte | 28 ++++++++++--------------
 ts/routes/graphs/Graph.svelte            |  4 ++--
 ts/routes/graphs/TrueRetention.svelte    |  4 ++--
 3 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/ts/lib/components/TitledContainer.svelte b/ts/lib/components/TitledContainer.svelte
index 70e4a078c..98983940a 100644
--- a/ts/lib/components/TitledContainer.svelte
+++ b/ts/lib/components/TitledContainer.svelte
@@ -12,7 +12,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     export { className as class };
 
     export let title: string;
-    export let onTitleClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null;
+    export let onHelpClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null;
 </script>
 
 <div
@@ -25,25 +25,21 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     style:--container-margin="0"
 >
     <div class="position-relative">
-        {#if onTitleClick}
-            <span
-                on:click={onTitleClick}
-                on:keydown={onTitleClick}
+        <h1>
+            {title}
+        </h1>
+        {#if onHelpClick}
+            <div
+                on:click={onHelpClick}
+                on:keydown={onHelpClick}
                 role="button"
                 tabindex="0"
+                class="help-badge position-absolute"
+                class:rtl
             >
-                <h1>
-                    {title}
-                </h1>
-            </span>
-        {:else}
-            <h1>
-                {title}
-            </h1>
+                <slot name="tooltip" />
+            </div>
         {/if}
-        <div class="help-badge position-absolute" class:rtl>
-            <slot name="tooltip" />
-        </div>
     </div>
     <slot />
 </div>
diff --git a/ts/routes/graphs/Graph.svelte b/ts/routes/graphs/Graph.svelte
index 2c509639e..1dafed4bb 100644
--- a/ts/routes/graphs/Graph.svelte
+++ b/ts/routes/graphs/Graph.svelte
@@ -8,7 +8,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     // When title is null (default), the graph is inlined, not having TitledContainer wrapper.
     export let title: string | null = null;
     export let subtitle: string | null = null;
-    export let onTitleClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null;
+    export let onHelpClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null;
 </script>
 
 {#if title == null}
@@ -19,7 +19,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         <slot />
     </div>
 {:else}
-    <TitledContainer class="d-flex flex-column" {title} {onTitleClick}>
+    <TitledContainer class="d-flex flex-column" {title} {onHelpClick}>
         <slot slot="tooltip" name="tooltip"></slot>
         <div class="graph d-flex flex-grow-1 flex-column justify-content-center">
             {#if subtitle}
diff --git a/ts/routes/graphs/TrueRetention.svelte b/ts/routes/graphs/TrueRetention.svelte
index 6b89ab9b8..9af2b4d85 100644
--- a/ts/routes/graphs/TrueRetention.svelte
+++ b/ts/routes/graphs/TrueRetention.svelte
@@ -57,12 +57,12 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
     const title = tr.statisticsTrueRetentionTitle();
     const subtitle = tr.statisticsTrueRetentionSubtitle();
-    const onTitleClick = () => {
+    const onHelpClick = () => {
         openHelpModal(Object.keys(retentionHelp).indexOf("trueRetention"));
     };
 </script>
 
-<Graph {title} {subtitle} {onTitleClick}>
+<Graph {title} {subtitle} {onHelpClick}>
     <HelpModal
         title={tr.statisticsTrueRetentionTitle()}
         url={HelpPage.DeckOptions.fsrs}