GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-20 06:52:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #1189 from RumovZ/fix-change-model

Browse source 
Fix browser.onChangeModel()
This commit is contained in:
Damien Elmes 2021-05-24 10:49:03 +10:00 committed by GitHub
commit 54a790c93e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
qt/aqt/browser/browser.py
View file

@ -498,21 +498,6 @@ class Browser(QMainWindow):
def selectedNotesAsCards(self) -> Sequence[CardId]: def selectedNotesAsCards(self) -> Sequence[CardId]:
return self.table.get_card_ids_from_selected_note_ids() return self.table.get_card_ids_from_selected_note_ids()
def oneModelNotes(self) -> Sequence[NoteId]:
sf = self.selected_notes()
if not sf:
return []
mods = self.col.db.scalar(
"""
select count(distinct mid) from notes
where id in %s"""
% ids2str(sf)
)
if mods > 1:
showInfo(tr.browsing_please_select_cards_from_only_one())
return []
return sf
def onHelp(self) -> None: def onHelp(self) -> None:
openHelp(HelpPage.BROWSING) openHelp(HelpPage.BROWSING)
@ -528,7 +513,17 @@ where id in %s"""
@skip_if_selection_is_empty @skip_if_selection_is_empty
@ensure_editor_saved @ensure_editor_saved
def onChangeModel(self) -> None: def onChangeModel(self) -> None:
ChangeModel(self, self.oneModelNotes()) ids = self.selected_notes()
if self._is_one_notetype(ids):
ChangeModel(self, ids)
else:
showInfo(tr.browsing_please_select_cards_from_only_one())
def _is_one_notetype(self, ids: Sequence[NoteId]) -> bool:
query = f"select count(distinct mid) from notes where id in {ids2str(ids)}"
if self.col.db.scalar(query) == 1:
return True
return False
def createFilteredDeck(self) -> None: def createFilteredDeck(self) -> None:
search = self.current_search() search = self.current_search()