From 5709183fe1e85991c20ee08c0cb35e7f547ab6ad Mon Sep 17 00:00:00 2001 From: Henrik Giesel Date: Sat, 24 Apr 2021 01:48:22 +0200 Subject: [PATCH] Prefer slicing and splicing --- ts/editor-toolbar/identifiable.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/ts/editor-toolbar/identifiable.ts b/ts/editor-toolbar/identifiable.ts index b9eff01f5..f44015d19 100644 --- a/ts/editor-toolbar/identifiable.ts +++ b/ts/editor-toolbar/identifiable.ts @@ -39,11 +39,8 @@ export function insert( const index = normalize(iterable, idOrIndex); if (index >= 0) { - iterable.items = [ - ...iterable.items.slice(0, index), - value, - ...iterable.items.slice(index), - ]; + iterable.items = iterable.items.slice(); + iterable.items.splice(index, 0, value); } return iterable; @@ -57,11 +54,8 @@ export function add( const index = normalize(iterable, idOrIndex); if (index >= 0) { - iterable.items = [ - ...iterable.items.slice(0, index + 1), - value, - ...iterable.items.slice(index + 1), - ]; + iterable.items = iterable.items.slice(); + iterable.items.splice(index + 1, 0, value); } return iterable;