From 58904dcad89cf6dd6efccc573d128a5219b86045 Mon Sep 17 00:00:00 2001 From: user1823 <92206575+user1823@users.noreply.github.com> Date: Sun, 5 Nov 2023 09:26:20 +0530 Subject: [PATCH] (FSRS) Improve presentation of log loss and RMSE (#2805) * (FSRS) Improve presentation of log loss and RMSE The number of decimal places in log loss have been increased from 3 to 4. Can help in better comparison of weights especially when the log loss with both are same up to 3 places of decimal. Also makes it consistent with the Python optimizer. RMSE has been expressed in percent, making it easier to interpret. * Fix formatting --------- Co-authored-by: Damien Elmes --- ts/deck-options/FsrsOptions.svelte | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ts/deck-options/FsrsOptions.svelte b/ts/deck-options/FsrsOptions.svelte index b8cbe803a..388eef561 100644 --- a/ts/deck-options/FsrsOptions.svelte +++ b/ts/deck-options/FsrsOptions.svelte @@ -120,11 +120,9 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html setTimeout( () => alert( - `Log loss: ${resp.logLoss.toFixed( - 3, - )}, RMSE(bins): ${resp.rmseBins.toFixed( - 3, - )}. ${tr.deckConfigSmallerIsBetter()}`, + `Log loss: ${resp.logLoss.toFixed(4)}, RMSE(bins): ${( + resp.rmseBins * 100 + ).toFixed(2)}%. ${tr.deckConfigSmallerIsBetter()}`, ), 200, );