GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

v2: limit learn delay fuzz to 5 minutes and sub-day

Browse source
This commit is contained in:
Damien Elmes 2018-07-28 13:49:04 +10:00
parent a728595c1d
commit 65f6ddf8d9
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
anki/schedv2.py
View file

@ -585,12 +585,13 @@ did = ? and queue = 3 and due <= ? limit ?""",
if delay is None: if delay is None:
delay = self._delayForGrade(conf, card.left) delay = self._delayForGrade(conf, card.left)
if card.due < time.time():
# not collapsed; add some randomness
delay *= random.uniform(1, 1.25)
card.due = int(time.time() + delay) card.due = int(time.time() + delay)
# due today? # due today?
if card.due < self.dayCutoff: if card.due < self.dayCutoff:
# add some randomness, up to 5 minutes or 25%
maxExtra = min(300, int(delay*0.25))
fuzz = random.randrange(0, maxExtra)
card.due = min(self.dayCutoff-1, card.due + fuzz)
card.queue = 1 card.queue = 1
if card.due < (intTime() + self.col.conf['collapseTime']): if card.due < (intTime() + self.col.conf['collapseTime']):
self.lrnCount += 1 self.lrnCount += 1

6
tests/test_schedv2.py
View file

@ -136,7 +136,8 @@ def test_learn():
# pass it once # pass it once
d.sched.answerCard(c, 3) d.sched.answerCard(c, 3)
# it should by due in 3 minutes # it should by due in 3 minutes
assert round(c.due - time.time()) in (179, 180) dueIn = c.due - time.time()
assert 179 <= dueIn <= 180*1.25
assert c.left%1000 == 2 assert c.left%1000 == 2
assert c.left//1000 == 2 assert c.left//1000 == 2
# check log is accurate # check log is accurate
@ -147,7 +148,8 @@ def test_learn():
# pass again # pass again
d.sched.answerCard(c, 3) d.sched.answerCard(c, 3)
# it should by due in 10 minutes # it should by due in 10 minutes
assert round(c.due - time.time()) in (599, 600) dueIn = c.due - time.time()
assert 599 <= dueIn <= 600*1.25
assert c.left%1000 == 1 assert c.left%1000 == 1
assert c.left//1000 == 1 assert c.left//1000 == 1
# the next pass should graduate the card # the next pass should graduate the card