Merge pull request #539 from Arthur-Milchior/remove_useless_recursion

Remove useless recursion in DeckManager.rem
This commit is contained in:
Damien Elmes 2020-04-06 15:32:05 +10:00 committed by GitHub
commit 69e8e3ffbc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -150,13 +150,13 @@ class DeckManager:
self.col.sched.emptyDyn(did) self.col.sched.emptyDyn(did)
if childrenToo: if childrenToo:
for name, id in self.children(did): for name, id in self.children(did):
self.rem(id, cardsToo) self.rem(id, cardsToo, childrenToo=False)
else: else:
# delete children first # delete children first
if childrenToo: if childrenToo:
# we don't want to delete children when syncing # we don't want to delete children when syncing
for name, id in self.children(did): for name, id in self.children(did):
self.rem(id, cardsToo) self.rem(id, cardsToo, childrenToo=False)
# delete cards too? # delete cards too?
if cardsToo: if cardsToo:
# don't use cids(), as we want cards in cram decks too # don't use cids(), as we want cards in cram decks too