GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Fix pasting of local links to unsupported types that contain spaces (#1813)

Browse source 
This change causes local links to unsupported formats like PDF to be
handled by _processUrls() instead of _processText, converting them to
correct hyperlinks in case they contain spaces.
This commit is contained in:
Abdo 2022-04-21 07:10:53 +03:00 committed by GitHub
parent 6f764aeda4
commit 6ea75df292
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
qt/aqt/editor.py
View file

@ -758,7 +758,9 @@ require("anki/ui").loaded.then(() => require("anki/NoteEditor").instances[0].too
def urlToLink(self, url: str) -> str | None: def urlToLink(self, url: str) -> str | None:
fname = self.urlToFile(url) fname = self.urlToFile(url)
if not fname: if not fname:
return None return '<a href="{}">{}</a>'.format(
url, html.escape(urllib.parse.unquote(url))
)
return self.fnameToLink(fname) return self.fnameToLink(fname)
def fnameToLink(self, fname: str) -> str: def fnameToLink(self, fname: str) -> str:
@ -1261,7 +1263,7 @@ class EditorWebView(AnkiWebView):
url = qurl.toString() url = qurl.toString()
# chrome likes to give us the URL twice with a \n # chrome likes to give us the URL twice with a \n
url = url.splitlines()[0] url = url.splitlines()[0]
buf += self.editor.urlToLink(url) or "" buf += self.editor.urlToLink(url)
return buf return buf
@ -1279,15 +1281,8 @@ class EditorWebView(AnkiWebView):
if extended and token.startswith("data:image/"): if extended and token.startswith("data:image/"):
processed.append(self.editor.inlinedImageToLink(token)) processed.append(self.editor.inlinedImageToLink(token))
elif extended and self.editor.isURL(token): elif extended and self.editor.isURL(token):
# if the user is pasting an image or sound link, convert it to local # if the user is pasting an image or sound link, convert it to local, otherwise paste as a hyperlink
link = self.editor.urlToLink(token) link = self.editor.urlToLink(token)
if link:
processed.append(link)
else:
# not media; add it as a normal link
link = '<a href="{}">{}</a>'.format(
token, html.escape(urllib.parse.unquote(token))
)
processed.append(link) processed.append(link)
else: else:
token = html.escape(token).replace("\t", " " * 4) token = html.escape(token).replace("\t", " " * 4)