From 6ef52726daa3d759abbf8c6a2d6f3c552d61c761 Mon Sep 17 00:00:00 2001
From: RumovZ <gp5glkw78@relay.firefox.com>
Date: Fri, 23 Jul 2021 10:32:29 +0200
Subject: [PATCH] Improve error message for unknown fragment

---
 rslib/src/links.rs | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/rslib/src/links.rs b/rslib/src/links.rs
index 69f125182..9cb1e439d 100644
--- a/rslib/src/links.rs
+++ b/rslib/src/links.rs
@@ -7,10 +7,10 @@ static HELP_SITE: &'static str = "https://docs.ankiweb.net/";
 
 impl HelpPage {
     pub fn to_link(self) -> String {
-        format!("{}{}", HELP_SITE, self.to_fragment())
+        format!("{}{}", HELP_SITE, self.to_link_suffix())
     }
 
-    fn to_fragment(self) -> &'static str {
+    fn to_link_suffix(self) -> &'static str {
         match self {
             HelpPage::NoteType => "getting-started#note-types",
             HelpPage::Browsing => "browsing",
@@ -74,9 +74,10 @@ mod test {
             Ok(url) => match check_web(&url, ctx).await {
                 Ok(()) => Outcome::Valid,
                 Err(Reason::Dom) => Outcome::Invalid(format!(
-                    "'{}' not found on '{}'",
-                    page.to_fragment(),
-                    HELP_SITE
+                    "'#{}' not found on '{}{}'",
+                    url.fragment().unwrap(),
+                    url.domain().unwrap(),
+                    url.path(),
                 )),
                 Err(Reason::Web(err)) => Outcome::Invalid(err.to_string()),
                 _ => unreachable!(),
@@ -98,7 +99,7 @@ mod test {
 
     impl Outcomes {
         fn message(&self) -> String {
-            iter::once(&format!("{} links could not be validated:", self.0.len()))
+            iter::once(&format!("{} link(s) could not be validated:", self.0.len()))
                 .chain(self.0.iter())
                 .join("\n  - ")
         }