GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

use rmse in comparing parameters (#3087)

Browse source
This commit is contained in:
Jarrett Ye 2024-03-24 16:28:15 +08:00 committed by GitHub
parent 36287888cc
commit 74a603e61b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rslib/src/scheduler/fsrs/weights.rs
View file

@ -93,10 +93,12 @@ impl Collection {
} }
}); });
let fsrs = FSRS::new(Some(current_weights))?; let fsrs = FSRS::new(Some(current_weights))?;
let current_rmse = fsrs.evaluate(items.clone(), |_| true)?.rmse_bins;
let mut weights = let mut weights =
fsrs.compute_parameters(items.clone(), fsrs_items < 1000, Some(progress2))?; fsrs.compute_parameters(items.clone(), fsrs_items < 1000, Some(progress2))?;
let metrics = fsrs.universal_metrics(items, &weights, |_| true)?; let optimized_fsrs = FSRS::new(Some(&weights))?;
if metrics.0 <= metrics.1 { let optimized_rmse = optimized_fsrs.evaluate(items.clone(), |_| true)?.rmse_bins;
if current_rmse <= optimized_rmse {
weights = current_weights.to_vec(); weights = current_weights.to_vec();
} }