From 75932db7349156244eaed25ee2e93e05a77ebc3d Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Mon, 18 Oct 2021 15:20:00 +1000 Subject: [PATCH] enable eslint on aqt/data/web/js --- qt/aqt/data/web/js/BUILD.bazel | 8 ++++---- qt/aqt/data/web/js/deckbrowser.ts | 2 +- qt/aqt/data/web/js/pycmd.d.ts | 2 +- qt/aqt/data/web/js/reviewer-bottom.ts | 10 +++++++--- qt/aqt/data/web/js/toolbar.ts | 4 ++++ 5 files changed, 17 insertions(+), 9 deletions(-) diff --git a/qt/aqt/data/web/js/BUILD.bazel b/qt/aqt/data/web/js/BUILD.bazel index aff15328e..b8fac74a4 100644 --- a/qt/aqt/data/web/js/BUILD.bazel +++ b/qt/aqt/data/web/js/BUILD.bazel @@ -60,10 +60,10 @@ prettier_test( ) # source files need fixing first -# eslint_test( -# name = "eslint", -# srcs = glob(["*.ts"]), -# ) +eslint_test( + name = "eslint", + srcs = glob(["*.ts"]), +) exports_files([ "mathjax.js", diff --git a/qt/aqt/data/web/js/deckbrowser.ts b/qt/aqt/data/web/js/deckbrowser.ts index 34ac83b04..78677653a 100644 --- a/qt/aqt/data/web/js/deckbrowser.ts +++ b/qt/aqt/data/web/js/deckbrowser.ts @@ -8,7 +8,7 @@ function init() { scroll: false, // can't use "helper: 'clone'" because of a bug in jQuery 1.5 - helper: function (event) { + helper: function (_event) { return $(this).clone(false); }, delay: 200, diff --git a/qt/aqt/data/web/js/pycmd.d.ts b/qt/aqt/data/web/js/pycmd.d.ts index 9cc761d8e..069af1a23 100644 --- a/qt/aqt/data/web/js/pycmd.d.ts +++ b/qt/aqt/data/web/js/pycmd.d.ts @@ -1 +1 @@ -declare function pycmd(cmd: string, result_callback?: (arg: any) => void): any; +declare function pycmd(cmd: string, result_callback?: (arg: unknown) => void): unknown; diff --git a/qt/aqt/data/web/js/reviewer-bottom.ts b/qt/aqt/data/web/js/reviewer-bottom.ts index ded498633..b13b8f6aa 100644 --- a/qt/aqt/data/web/js/reviewer-bottom.ts +++ b/qt/aqt/data/web/js/reviewer-bottom.ts @@ -1,7 +1,11 @@ /* Copyright: Ankitects Pty Ltd and contributors * License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html */ -var time: number; // set in python code +/* eslint +@typescript-eslint/no-unused-vars: "off", +*/ + +let time: number; // set in python code let maxTime = 0; document.addEventListener("DOMContentLoaded", () => { @@ -41,8 +45,8 @@ function showAnswer(txt: string): void { document.getElementById("middle").innerHTML = txt; } -function selectedAnswerButton() { - let node = document.activeElement as HTMLElement; +function selectedAnswerButton(): string { + const node = document.activeElement as HTMLElement; if (!node) { return; } diff --git a/qt/aqt/data/web/js/toolbar.ts b/qt/aqt/data/web/js/toolbar.ts index abc4e1e1c..b8e4f6be8 100644 --- a/qt/aqt/data/web/js/toolbar.ts +++ b/qt/aqt/data/web/js/toolbar.ts @@ -1,6 +1,10 @@ // Copyright: Ankitects Pty Ltd and contributors // License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html +/* eslint +@typescript-eslint/no-unused-vars: "off", +*/ + enum SyncState { NoChanges = 0, Normal,