From 7ce237efae3567b086e478459acb56a73e595b48 Mon Sep 17 00:00:00 2001 From: Jarrett Ye Date: Mon, 4 Aug 2025 19:58:22 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: user1823 <92206575+user1823@users.noreply.github.com> --- rslib/src/revlog/mod.rs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/rslib/src/revlog/mod.rs b/rslib/src/revlog/mod.rs index 67c185cb0..f52698388 100644 --- a/rslib/src/revlog/mod.rs +++ b/rslib/src/revlog/mod.rs @@ -88,19 +88,21 @@ impl RevlogEntry { /// Returns true if this entry represents a reset operation. /// These entries are created when a card is reset using /// [`Collection::reschedule_cards_as_new`]. - /// The `ease_factor` should be 0 because - /// [`Collection::set_due_date`] also sets created `RevlogEntry` with - /// `RevlogReviewKind::Manual` but the `ease_factor` is not 0. + /// The 0 value of `ease_factor` differentiates it + /// from entry created by [`Collection::set_due_date`] that has + /// `RevlogReviewKind::Manual` but non-zero `ease_factor`. pub(crate) fn is_reset(&self) -> bool { self.review_kind == RevlogReviewKind::Manual && self.ease_factor == 0 } /// Returns true if this entry represents a cramming operation. - /// These entries are created when a card is previewed using + /// These entries are created when a card is reviewed in a + /// filtered deck with "Reschedule cards based on my answers + /// in this deck" disabled. /// [`crate::scheduler::answering::CardStateUpdater::apply_preview_state`]. - /// The `ease_factor` should be 0 because - /// [`crate::scheduler::states::ReviewState::revlog_kind`] returns - /// `RevlogReviewKind::Filtered` when `days_late() < 0`. + /// The 0 value of `ease_factor` distinguishes it from the entry + /// created when a card is reviewed before its due date in a + /// filtered deck with reschedule enabled or using Grade Now. pub(crate) fn is_cramming(&self) -> bool { self.review_kind == RevlogReviewKind::Filtered && self.ease_factor == 0 }