From 7e58660aabd8019d6c35a49dabf1c7c767496877 Mon Sep 17 00:00:00 2001
From: Henrik Giesel <hengiesel@gmail.com>
Date: Sat, 9 Jan 2021 14:04:57 +0100
Subject: [PATCH] Modify default behavior of rated searches to exclude manual

---
 rslib/src/search/parser.rs    | 36 ++++++++++++++++++++++++++++-------
 rslib/src/search/sqlwriter.rs | 16 ++++++----------
 rslib/src/search/writer.rs    | 10 ++++++----
 3 files changed, 41 insertions(+), 21 deletions(-)

diff --git a/rslib/src/search/parser.rs b/rslib/src/search/parser.rs
index 6274914eb..52d00b8d3 100644
--- a/rslib/src/search/parser.rs
+++ b/rslib/src/search/parser.rs
@@ -69,7 +69,7 @@ pub enum SearchNode<'a> {
     NoteType(Cow<'a, str>),
     Rated {
         days: u32,
-        ease: Option<u8>,
+        ease: EaseKind,
     },
     Tag(Cow<'a, str>),
     Duplicates {
@@ -118,6 +118,25 @@ pub enum TemplateKind<'a> {
     Name(Cow<'a, str>),
 }
 
+#[derive(Debug, PartialEq, Clone)]
+pub(super) enum EaseKind {
+    Rated(u8),
+    Reviewed,
+    All,
+}
+
+impl std::fmt::Display for EaseKind {
+    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+        use EaseKind::*;
+
+        match self {
+            Rated(u) => write!(f, " and ease = {}", u),
+            Reviewed => write!(f, " and ease in (1, 2, 3, 4)"),
+            All => write!(f, ""),
+        }
+    }
+}
+
 /// Parse the input string into a list of nodes.
 pub(super) fn parse(input: &str) -> Result<Vec<Node>> {
     let input = input.trim();
@@ -359,14 +378,17 @@ fn parse_rated(val: &str) -> ParseResult<SearchNode<'static>> {
 
     let ease = match it.next() {
         Some(v) => {
-            let n: u8 = v.parse()?;
-            if n < 5 {
-                Some(n)
-            } else {
-                return Err(ParseError {});
+            let c: char = v.parse().unwrap();
+            match c {
+                '0' | '1' | '2' | '3' | '4' => {
+                    let n = c.to_digit(10).unwrap() as u8;
+                    EaseKind::Rated(n)
+                }
+                'a' => EaseKind::All,
+                _ => return Err(ParseError {}),
             }
         }
-        None => None,
+        None => EaseKind::Reviewed,
     };
 
     Ok(SearchNode::Rated { days, ease })
diff --git a/rslib/src/search/sqlwriter.rs b/rslib/src/search/sqlwriter.rs
index caac139e9..3f447dea3 100644
--- a/rslib/src/search/sqlwriter.rs
+++ b/rslib/src/search/sqlwriter.rs
@@ -1,7 +1,7 @@
 // Copyright: Ankitects Pty Ltd and contributors
 // License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-use super::parser::{Node, PropertyKind, SearchNode, StateKind, TemplateKind};
+use super::parser::{Node, PropertyKind, SearchNode, StateKind, TemplateKind, EaseKind};
 use crate::{
     card::{CardQueue, CardType},
     collection::Collection,
@@ -144,7 +144,7 @@ impl SqlWriter<'_> {
                 write!(self.sql, "c.did = {}", did).unwrap();
             }
             SearchNode::NoteType(notetype) => self.write_note_type(&norm(notetype))?,
-            SearchNode::Rated { days, ease } => self.write_rated(*days, *ease)?,
+            SearchNode::Rated { days, ease } => self.write_rated(*days, ease)?,
 
             SearchNode::Tag(tag) => self.write_tag(&norm(tag))?,
             SearchNode::State(state) => self.write_state(state)?,
@@ -214,20 +214,16 @@ impl SqlWriter<'_> {
         Ok(())
     }
 
-    fn write_rated(&mut self, days: u32, ease: Option<u8>) -> Result<()> {
+    fn write_rated(&mut self, days: u32, ease: &EaseKind) -> Result<()> {
         let today_cutoff = self.col.timing_today()?.next_day_at;
         let target_cutoff_ms = (today_cutoff - 86_400 * i64::from(days)) * 1_000;
         write!(
             self.sql,
-            "c.id in (select cid from revlog where id>{}",
-            target_cutoff_ms
+            "c.id in (select cid from revlog where id>{}{})",
+            target_cutoff_ms,
+            ease,
         )
         .unwrap();
-        if let Some(ease) = ease {
-            write!(self.sql, " and ease={})", ease).unwrap();
-        } else {
-            write!(self.sql, ")").unwrap();
-        }
 
         Ok(())
     }
diff --git a/rslib/src/search/writer.rs b/rslib/src/search/writer.rs
index 6507f3be9..61e5ee850 100644
--- a/rslib/src/search/writer.rs
+++ b/rslib/src/search/writer.rs
@@ -5,7 +5,7 @@ use crate::{
     decks::DeckID as DeckIDType,
     err::Result,
     notetype::NoteTypeID as NoteTypeIDType,
-    search::parser::{parse, Node, PropertyKind, SearchNode, StateKind, TemplateKind},
+    search::parser::{parse, Node, PropertyKind, SearchNode, StateKind, TemplateKind, EaseKind},
 };
 use itertools::Itertools;
 use std::mem;
@@ -154,10 +154,12 @@ fn write_template(template: &TemplateKind) -> String {
     }
 }
 
-fn write_rated(days: &u32, ease: &Option<u8>) -> String {
+fn write_rated(days: &u32, ease: &EaseKind) -> String {
+    use EaseKind::*;
     match ease {
-        Some(u) => format!("\"rated:{}:{}\"", days, u),
-        None => format!("\"rated:{}\"", days),
+        Rated(n) => format!("\"rated:{}:{}\"", days, n),
+        Reviewed => format!("\"rated:{}\"", days),
+        All => format!("\"rated:{}:a\"", days),
     }
 }