From 7f12814bbedfe7ce3088020826538f4ac6f7ab9d Mon Sep 17 00:00:00 2001
From: Omar Kohl <omarkohl@posteo.net>
Date: Sat, 4 Jan 2025 15:51:43 +0100
Subject: [PATCH] avoid warning by setting SYNC_PORT as ARG in Dockerfile
 (#3675)

* Add myself to CONTRIBUTORS file

* avoid warning by setting SYNC_PORT as ARG in Dockerfile

    1 warning found (use docker --debug to expand):
    - UndefinedVar: Usage of undefined variable '$SYNC_PORT'
---
 CONTRIBUTORS                          | 1 +
 docs/syncserver/Dockerfile            | 4 +++-
 docs/syncserver/Dockerfile.distroless | 6 ++++--
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index daf37166e..86af3cd7e 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -203,6 +203,7 @@ hideo aoyama <https://github.com/boukendesho>
 Ross Brown <rbrownwsws@googlemail.com>
 🦙 <github.com/iamllama>
 Lukas Sommer <sommerluk@gmail.com>
+Omar Kohl <omarkohl@posteo.net>
 
 ********************
 
diff --git a/docs/syncserver/Dockerfile b/docs/syncserver/Dockerfile
index 21e343ca6..b313148e9 100644
--- a/docs/syncserver/Dockerfile
+++ b/docs/syncserver/Dockerfile
@@ -11,6 +11,8 @@ anki-sync-server
 
 FROM alpine:3.20.2
 
+ARG SYNC_PORT=8080
+
 RUN adduser -D -h /home/anki anki
 
 COPY --from=builder /anki-server/bin/anki-sync-server /usr/local/bin/anki-sync-server
@@ -20,7 +22,7 @@ RUN apk update && apk add --no-cache bash && rm -rf /var/cache/apk/*
 
 USER anki
 
-ENV SYNC_PORT=${SYNC_PORT:-"8080"}
+ENV SYNC_PORT=${SYNC_PORT}
 
 EXPOSE ${SYNC_PORT}
 
diff --git a/docs/syncserver/Dockerfile.distroless b/docs/syncserver/Dockerfile.distroless
index 6bfdf9e07..0f19fa610 100644
--- a/docs/syncserver/Dockerfile.distroless
+++ b/docs/syncserver/Dockerfile.distroless
@@ -11,9 +11,11 @@ anki-sync-server
 
 FROM gcr.io/distroless/cc-debian12
 
+ARG SYNC_PORT=8080
+
 COPY --from=builder /anki-server/bin/anki-sync-server /usr/bin/anki-sync-server
 
-ENV SYNC_PORT=${SYNC_PORT:-"8080"}
+ENV SYNC_PORT=${SYNC_PORT}
 
 EXPOSE ${SYNC_PORT}
 
@@ -24,4 +26,4 @@ CMD ["anki-sync-server"]
 HEALTHCHECK --interval=30s --timeout=10s --start-period=5s --retries=3 \
 CMD ["anki-sync-server", "--healthcheck"]
 
-LABEL maintainer="Jean Khawand <jk@jeankhawand.com>"
\ No newline at end of file
+LABEL maintainer="Jean Khawand <jk@jeankhawand.com>"