GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Add some unit tests (#3678)

Browse source 
* Add some unit tests

Covers most of the cases encountered in https://github.com/ankitects/anki/pull/3639

* Format

* Update params.rs

Makes the test more robust.

* Update params.rs

When training, the first FSRS item is removed. That's why none of the other tests includes it.

Co-authored-by: Jarrett Ye <jarrett.ye@outlook.com>

* Improve naming

* Fix typo

---------

Co-authored-by: Jarrett Ye <jarrett.ye@outlook.com>
This commit is contained in:
user1823 2025-01-04 19:56:23 +05:30 committed by GitHub
parent 9d1be9a413
commit 7fa544df9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 70 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
rslib/src/scheduler/fsrs/params.rs
View file

@ -545,11 +545,12 @@ pub(crate) mod tests {
#[test] #[test]
fn card_reset_drops_all_previous_history() { fn card_reset_drops_all_previous_history() {
// If Reset comes in between two Learn entries, only the ones after the Reset
// are used.
assert_eq!( assert_eq!(
convert( convert(
&[ &[
revlog(RevlogReviewKind::Learning, 10), revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry { RevlogEntry {
ease_factor: 0, ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7) ..revlog(RevlogReviewKind::Manual, 7)
@ -561,6 +562,58 @@ pub(crate) mod tests {
), ),
fsrs_items!([review(0), review(4)]) fsrs_items!([review(0), review(4)])
); );
// Return None if Reset is the last entry or is followed by only manual entries.
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
RevlogEntry {
ease_factor: 100,
..revlog(RevlogReviewKind::Manual, 7)
},
],
false,
),
None,
);
// If non-learning user-graded entries are found after Reset, return None during
// training but return the remaining entries during memory state calculation.
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Learning, 10),
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
revlog(RevlogReviewKind::Review, 1),
revlog(RevlogReviewKind::Relearning, 0),
],
true,
),
None,
);
assert_eq!(
convert(
&[
revlog(RevlogReviewKind::Review, 9),
RevlogEntry {
ease_factor: 0,
..revlog(RevlogReviewKind::Manual, 7)
},
revlog(RevlogReviewKind::Review, 1),
revlog(RevlogReviewKind::Relearning, 0),
],
false,
),
fsrs_items!([review(0)], [review(0), review(1)])
);
} }
#[test] #[test]
@ -636,4 +689,20 @@ pub(crate) mod tests {
convert(revlogs, false) convert(revlogs, false)
); );
} }
#[test]
fn handle_ignore_before_when_no_learning_steps() {
let revlogs = &[
revlog(RevlogReviewKind::Review, 10),
revlog(RevlogReviewKind::Review, 8),
revlog(RevlogReviewKind::Review, 6),
];
// R | R R
assert_eq!(
convert_ignore_before(revlogs, false, days_ago_ms(9))
.unwrap()
.len(),
2
);
}
} }