From 84bd035dc87efe7d6eb2323576ffbd3d8c123d45 Mon Sep 17 00:00:00 2001
From: Matthias Metelka <62722460+kleinerpirat@users.noreply.github.com>
Date: Mon, 16 Jan 2023 08:44:09 +0100
Subject: [PATCH] Improve Preferences layout by adding vertical spacers to the
 bottom

also make the hiding of video_driver and its label more obvious in preferences.py.
---
 qt/aqt/forms/preferences.ui | 45 ++++++++++++++++++++++++++-----------
 qt/aqt/preferences.py       |  5 +++--
 2 files changed, 35 insertions(+), 15 deletions(-)

diff --git a/qt/aqt/forms/preferences.ui b/qt/aqt/forms/preferences.ui
index 1baa50636..8bf4477ac 100644
--- a/qt/aqt/forms/preferences.ui
+++ b/qt/aqt/forms/preferences.ui
@@ -29,6 +29,12 @@
       <layout class="QVBoxLayout" name="verticalLayout_8">
        <item>
         <widget class="QGroupBox" name="generalGroup">
+         <property name="sizePolicy">
+          <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+           <horstretch>0</horstretch>
+           <verstretch>0</verstretch>
+          </sizepolicy>
+         </property>
          <property name="title">
           <string>preferences_general</string>
          </property>
@@ -213,6 +219,19 @@
          </layout>
         </widget>
        </item>
+       <item>
+        <spacer name="verticalSpacer_9">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>40</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
       </layout>
      </widget>
      <widget class="QWidget" name="tab_3">
@@ -433,6 +452,19 @@
          </layout>
         </widget>
        </item>
+       <item>
+        <spacer name="verticalSpacer_12">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>40</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
       </layout>
      </widget>
      <widget class="QWidget" name="tab_1">
@@ -982,19 +1014,6 @@
      </widget>
     </widget>
    </item>
-   <item>
-    <spacer name="verticalSpacer">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>16</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
    <item>
     <widget class="QLabel" name="someSettingsLabel">
      <property name="text">
diff --git a/qt/aqt/preferences.py b/qt/aqt/preferences.py
index aac60b842..1fd6f8aac 100644
--- a/qt/aqt/preferences.py
+++ b/qt/aqt/preferences.py
@@ -334,8 +334,9 @@ class Preferences(QDialog):
         self.form.video_driver.setCurrentIndex(
             self.video_drivers.index(self.mw.pm.video_driver())
         )
-        self.form.video_driver_label.setVisible(qtmajor == 5)
-        self.form.video_driver.setVisible(qtmajor == 5)
+        if qtmajor > 5:
+            self.form.video_driver_label.setVisible(False)
+            self.form.video_driver.setVisible(False)
 
     def update_video_driver(self) -> None:
         new_driver = self.video_drivers[self.form.video_driver.currentIndex()]