From 85215018a5178311f8f63a7d3227e02457378a2c Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Tue, 12 Jul 2016 13:53:59 +1000 Subject: [PATCH] another approach to fixing modSchema bug start the progress dialog immediately so that askUser() becomes part of the progress dialog's modality the problem with the previous approach was that beginReset() attempts to save the note again, leading to schema mismatches --- aqt/browser.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/aqt/browser.py b/aqt/browser.py index e5c4fb322..6446b1c98 100644 --- a/aqt/browser.py +++ b/aqt/browser.py @@ -1671,8 +1671,7 @@ Are you sure you want to continue?""")): QDialog.accept(self) self.browser.mw.checkpoint(_("Change Note Type")) b = self.browser - b.mw.col.modSchema(check=True) - b.mw.progress.start() + b.mw.progress.start(immediate=True) b.model.beginReset() mm = b.mw.col.models mm.change(self.oldModel, self.nids, self.targetModel, fmap, cmap)