GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-23 00:12:25 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Switch strong/em back to b/i

Browse source 
In the absence of strong arguments either way, and given the fact that
strong/em has broken a few (perhaps rare) use-cases, reverting seems
prudent. But happy to revisit this again in the future if someone has
a convincing argument for why we should be doing it differently.

Closes #1807
This commit is contained in:
Damien Elmes 2022-04-19 16:28:44 +10:00
parent 6017214042
commit 856d4763a9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ts/editor/editor-toolbar/BoldButton.svelte
View file

@ -15,7 +15,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
import { context as editorToolbarContext } from "./EditorToolbar.svelte"; import { context as editorToolbarContext } from "./EditorToolbar.svelte";
import { boldIcon } from "./icons"; import { boldIcon } from "./icons";
const surroundElement = document.createElement("strong"); const surroundElement = document.createElement("b");
function matcher(element: HTMLElement | SVGElement, match: MatchType): void { function matcher(element: HTMLElement | SVGElement, match: MatchType): void {
if (element.tagName === "B" || element.tagName === "STRONG") { if (element.tagName === "B" || element.tagName === "STRONG") {

2
ts/editor/editor-toolbar/ItalicButton.svelte
View file

@ -15,7 +15,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
import { context as editorToolbarContext } from "./EditorToolbar.svelte"; import { context as editorToolbarContext } from "./EditorToolbar.svelte";
import { italicIcon } from "./icons"; import { italicIcon } from "./icons";
const surroundElement = document.createElement("em"); const surroundElement = document.createElement("i");
function matcher(element: HTMLElement | SVGElement, match: MatchType): void { function matcher(element: HTMLElement | SVGElement, match: MatchType): void {
if (element.tagName === "I" || element.tagName === "EM") { if (element.tagName === "I" || element.tagName === "EM") {