GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 14:02:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Add title for some dialogs and avoid hardcoding the text of the discard changes dialog (#3846)

Browse source 
* feat: add title to rename dialog

* fix: localize hardcoded message

* feat: add title to create deck dialog

* refactor: formatting fixes

* add name to about screen

adding my name to contributors for the third time
This commit is contained in:
Brayan Oliveira 2025-03-10 05:53:43 -03:00 committed by GitHub
parent d8460d354a
commit 94e90dbf85
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTORS
View file

@ -98,7 +98,7 @@ gnnoh <gerongfenh@gmail.com>
Sachin Govind <sachin.govind.too@gmail.com> Sachin Govind <sachin.govind.too@gmail.com>
Bruce Harris <github.com/bruceharris> Bruce Harris <github.com/bruceharris>
Patric Cunha <patricc@agap2.pt> Patric Cunha <patricc@agap2.pt>
Brayan Oliveira <github.com/brayandso> Brayan Oliveira <69634269+BrayanDSO@users.noreply.github.com>
Luka Warren <github.com/lukawarren> Luka Warren <github.com/lukawarren>
wisherhxl <wisherhxl@gmail.com> wisherhxl <wisherhxl@gmail.com>
dobefore <1432338032@qq.com> dobefore <1432338032@qq.com>

1
qt/aqt/about.py
View file

@ -215,6 +215,7 @@ def show(mw: aqt.AnkiQt) -> QDialog:
"Danika_Dakika", "Danika_Dakika",
"Marcelo Vasconcelos", "Marcelo Vasconcelos",
"Mumtaz Hajjo Alrifai", "Mumtaz Hajjo Alrifai",
"Brayan Oliveira",
) )
) )

4
qt/aqt/deckbrowser.py
View file

@ -328,7 +328,9 @@ class DeckBrowser:
def _rename(self, did: DeckId) -> None: def _rename(self, did: DeckId) -> None:
def prompt(name: str) -> None: def prompt(name: str) -> None:
new_name = getOnlyText(tr.decks_new_deck_name(), default=name) new_name = getOnlyText(
tr.decks_new_deck_name(), default=name, title=tr.actions_rename()
)
if not new_name or new_name == name: if not new_name or new_name == name:
return return
else: else:

2
qt/aqt/fields.py
View file

@ -288,7 +288,7 @@ class FieldDialog(QDialog):
self.webview = None self.webview = None
if self.change_tracker.changed(): if self.change_tracker.changed():
if not askUser("Discard changes?"): if not askUser(tr.card_templates_discard_changes()):
return return
QDialog.reject(self) QDialog.reject(self)

5
qt/aqt/operations/deck.py
View file

@ -59,7 +59,10 @@ def add_deck_dialog(
default_text: str = "", default_text: str = "",
) -> CollectionOp[OpChangesWithId] | None: ) -> CollectionOp[OpChangesWithId] | None:
if name := getOnlyText( if name := getOnlyText(
tr.decks_new_deck_name(), default=default_text, parent=parent tr.decks_new_deck_name(),
default=default_text,
parent=parent,
title=tr.decks_create_deck(),
).strip(): ).strip():
return add_deck(parent=parent, name=name) return add_deck(parent=parent, name=name)
else: else: