diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 7064c6885..e093d3bc6 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -243,6 +243,7 @@ Lee Doughty <32392044+leedoughty@users.noreply.github.com> memchr Max Romanowski Aldlss +Amanda Sternberg ******************** diff --git a/rslib/src/media/files.rs b/rslib/src/media/files.rs index ce17b40bb..f0c75c965 100644 --- a/rslib/src/media/files.rs +++ b/rslib/src/media/files.rs @@ -320,6 +320,20 @@ pub(crate) fn mtime_as_i64>(path: P) -> io::Result { .as_millis() as i64) } +/// On POSIX this is EXDEV (error 18) and on Windows it is ERROR_NOT_SAME_DEVICE +/// (error 17). +pub(crate) fn safe_rename(src: &Path, dst: &Path) -> io::Result<()> { + match fs::rename(src, dst) { + Ok(_) => Ok(()), + Err(e) if e.kind() == io::ErrorKind::CrossesDevices => { + fs::copy(src, dst)?; + fs::remove_file(src)?; + Ok(()) + } + Err(e) => Err(e), + } +} + pub fn remove_files(media_folder: &Path, files: &[S]) -> Result<()> where S: AsRef + std::fmt::Debug, @@ -344,7 +358,7 @@ where } // move file to trash, clobbering any existing file with the same name - fs::rename(&src_path, &dst_path)?; + safe_rename(&src_path, &dst_path)?; // mark it as modified, so we can expire it in the future let secs = time::SystemTime::now(); @@ -437,9 +451,11 @@ pub(crate) fn data_for_file(media_folder: &Path, fname: &str) -> Result::Owned(format!("{}_", " ".repeat(MAX_MEDIA_FILENAME_LENGTH - 2))) ); } + #[test] + fn safe_rename_moves_file() { + // This test only verifies that ´safe_rename´calls back to copy+remove logic + // when needed. It does not simulate a real cross-device move. + let dir = tempdir().unwrap(); + let src = dir.path().join("test_src.txt"); + let dst = dir.path().join("test_dst.txt"); + + fs::write(&src, b"hello world").unwrap(); + safe_rename(&src, &dst).unwrap(); + + assert!(dst.exists()); + assert!(!src.exists()); + let contents = fs::read(&dst).unwrap(); + assert_eq!(contents, b"hello world"); + + fs::remove_file(&dst).unwrap(); + } }