GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-13 14:03:55 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Refactor desired retention logic in Collection implementation

Browse source 
Updated the logic for retrieving deck-specific desired retention in both `memory_state.rs` and `mod.rs` to handle cases where the deck's normal state may not be available. This change ensures that the default configuration is used when necessary, improving the robustness of the retention handling.
This commit is contained in:
Jarrett Ye 2025-07-10 12:14:11 +08:00
parent eef199830e
commit 9d7dc2350f
No known key found for this signature in database
GPG key ID: EBFC55E0C1A352BB
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rslib/src/scheduler/answering/mod.rs
View file

@ -447,8 +447,10 @@ impl Collection {
// Get deck-specific desired retention if available, otherwise use config // Get deck-specific desired retention if available, otherwise use config
// default // default
let desired_retention = if let Some(deck_dr) = deck.normal()?.desired_retention { let desired_retention = if let Ok(normal_deck) = deck.normal() {
deck_dr normal_deck
.desired_retention
.unwrap_or(config.inner.desired_retention)
} else { } else {
config.inner.desired_retention config.inner.desired_retention
}; };

6
rslib/src/scheduler/fsrs/memory_state.rs
View file

@ -208,8 +208,10 @@ impl Collection {
// Get deck-specific desired retention if available, otherwise use config // Get deck-specific desired retention if available, otherwise use config
// default // default
let desired_retention = if let Some(deck_dr) = deck.normal()?.desired_retention { let desired_retention = if let Ok(normal_deck) = deck.normal() {
deck_dr normal_deck
.desired_retention
.unwrap_or(config.inner.desired_retention)
} else { } else {
config.inner.desired_retention config.inner.desired_retention
}; };