From 9dda28def4d57ef461a210da498fe79532345465 Mon Sep 17 00:00:00 2001 From: evandrocoan Date: Fri, 17 Apr 2020 16:23:13 -0300 Subject: [PATCH] Also limit the size of the error message in case it is build by a concatenation of stack traces, i.e., ```js throw new Error(err + err.stack) ``` --- qt/ts/src/reviewer.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/qt/ts/src/reviewer.ts b/qt/ts/src/reviewer.ts index 4a854228d..3cf2bc41d 100644 --- a/qt/ts/src/reviewer.ts +++ b/qt/ts/src/reviewer.ts @@ -40,11 +40,12 @@ function _updateQA(html, fadeTime, onupdate, onshown) { qa.html(html); } catch (err) { qa.html( - "Invalid HTML on card: " + - err + - ("\n" + err.stack) - .substring(0, 2000) - .replace(/\n/g, "
") + ( + `Invalid HTML on card: ${String(err).substring( + 0, + 2000 + )}\n` + String(err.stack).substring(0, 2000) + ).replace(/\n/g, "
") ); } _runHook(onUpdateHook);