Enable invalid-name globally in pylib (#1454)

pylib/.pylintrc

@@ -26,7 +26,6 @@ output-format=colorized
 [MESSAGES CONTROL]
 disable=
   R,
-  invalid-name,
   line-too-long,
   too-many-lines,
   missing-function-docstring,

pylib/anki/__init__.py

@@ -1,4 +1,2 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
-
-# pylint: enable=invalid-name

pylib/anki/_backend/__init__.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import sys

pylib/anki/_backend/genbackend.py

@@ -2,8 +2,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 import os
 import re
 import sys

pylib/anki/_backend/genfluent.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 import json
 import sys
 from typing import List, Literal, TypedDict

pylib/anki/_legacy.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import functools

pylib/anki/browser.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 
 class BrowserConfig:
     ACTIVE_CARD_COLUMNS_KEY = "activeCols"

pylib/anki/buildinfo.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from importlib.resources import open_text
 
 

pylib/anki/cards.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import pprint

pylib/anki/collection.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 from typing import Any, Generator, Literal, Sequence, Union, cast

pylib/anki/config.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 Config handling
 

pylib/anki/consts.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import sys

pylib/anki/db.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 A convenience wrapper over pysqlite.
 

pylib/anki/dbproxy.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import re

pylib/anki/decks.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import copy

pylib/anki/errors.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 from enum import Enum

pylib/anki/find.py

@@ -1,6 +1,8 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
+# pylint: disable=invalid-name
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING

pylib/anki/hooks.py

@@ -1,6 +1,8 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
+# pylint: disable=invalid-name
+
 """
 Tools for extending Anki.
 

pylib/anki/httpclient.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 Wrapper for requests that adds a callback for tracking upload/download progress.
 """

pylib/anki/importing/base.py

@@ -1,6 +1,8 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
+# pylint: disable=invalid-name
+
 from typing import Any, Optional
 
 from anki.collection import Collection

pylib/anki/importing/csvfile.py

@@ -1,6 +1,8 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
+# pylint: disable=invalid-name
+
 from __future__ import annotations
 
 import csv

pylib/anki/importing/pauker.py

@@ -1,6 +1,8 @@
 # Copyright: Andreas Klauer <Andreas.Klauer@metamorpher.de>
 # License: BSD-3
 
+# pylint: disable=invalid-name
+
 import gzip
 import html
 import math

pylib/anki/lang.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import locale

pylib/anki/latex.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import html

pylib/anki/media.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import os

pylib/anki/models.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import copy

pylib/anki/notes.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import copy

pylib/anki/scheduler/__init__.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import sys

pylib/anki/scheduler/base.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import anki

pylib/anki/scheduler/v3.py

@@ -1,6 +1,8 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
+# pylint: disable=invalid-name
+
 """
 This file contains experimental scheduler changes:
 

pylib/anki/sound.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 Sound/TTS references extracted from card text.
 

pylib/anki/statsbg.py

@@ -1,3 +1,5 @@
+# pylint: disable=invalid-name
+
 # from subtlepatterns.com; CC BY-SA 3.0.
 # by Daniel Beaton
 # https://www.toptal.com/designers/subtlepatterns/fancy-deboss/

pylib/anki/stdmodels.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 from typing import Any, Callable, no_type_check

pylib/anki/storage.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 # Legacy code expects to find Collection in this module.
 
 from anki.collection import Collection

pylib/anki/sync.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from anki import sync_pb2
 
 # public exports

pylib/anki/syncserver/__init__.py

@@ -4,8 +4,6 @@
 # Please see /docs/syncserver.md
 #
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import gzip

pylib/anki/syncserver/__main__.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from anki.syncserver import serve
 
 serve()

pylib/anki/tags.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 Anki maintains a cache of used tags so it can quickly present a list of tags
 for autocomplete and in the browser. For efficiency, deletions are not

pylib/anki/template.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 """
 This file contains the Python portion of the template rendering code.
 

pylib/anki/types.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from typing import NoReturn
 
 

pylib/anki/utils.py

@@ -1,8 +1,6 @@
 # Copyright: Ankitects Pty Ltd and contributors
 # License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
-# pylint: enable=invalid-name
-
 from __future__ import annotations
 
 import json as _json