From ad2c17aced5250d826e912458909029ba2c0e311 Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Mon, 18 Oct 2021 22:24:06 +1000 Subject: [PATCH] docs: the old TS flakiness should be gone, but renames are a problem --- docs/development.md | 12 +++++++----- docs/windows.md | 8 ++------ 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/docs/development.md b/docs/development.md index 95b0cb5fc..66abd64cb 100644 --- a/docs/development.md +++ b/docs/development.md @@ -203,11 +203,13 @@ Recording also requires `lame` to be in your system path. If you get errors with @npm and node_modules in the message, try deleting the node_modules folder. -Unlike the old Make system, a "clean build" should almost never be required -unless you are debugging issues with the build system. But if you need to get -things to a fresh state, you can run `bazel clean --expunge`. After doing so, -make sure you remove the node_modules folder, or subsequent build commands -will fail with a "no such file or directory node_modules/anki" message. +On Windows, you may run into 'could not write file' messages when TypeScript +files are renamed, as the old build products are not being cleaned up correctly. +You can either remove the problem folder (eg +bazel-out/x64_windows-fastbuild/bin/ts/projectname), or do a full clean. + +To do a full clean, use a `bazel clean --expunge`, and then remove the node_modules +folder. ## Tracing build problems diff --git a/docs/windows.md b/docs/windows.md index 913c5d0e8..7767196b2 100644 --- a/docs/windows.md +++ b/docs/windows.md @@ -25,9 +25,9 @@ After installation completes, run msys2, and run the following command: $ pacman -S git ``` -**Bazelisk**: +**Bazel**: -Use Start>Run to open PowerShell. Create a folder to store Bazelisk +Use Start>Run to open PowerShell. Create a folder to store Bazel and its working data. Anki's build scripts expect to find it in \bazel on the same drive as the source folder. ``` @@ -61,10 +61,6 @@ This will build Anki and run it in place. The first build will take a while, as it downloads and builds a bunch of dependencies. When the build is complete, Anki will automatically start. -The Javascript build code is currently a bit flaky, so the initial -build may fail with an error. If you get an error when running/building, -try repeating the command once or twice - it should pick up where it left off. - To play and record audio, mpv.exe and lame.exe must be on the path. ## Optimized builds