GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-20 06:52:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

switch 'set due date' to leaving the interval alone for now

Browse source 
The previous approach worked when the user pushes their due date back,
or moves it forward a little bit, but breaks down if they reschedule
shortly after the previous answer - a card that was only just answered
will have had an effective delay of 0, causing the interval to be
reset, which is not great.

I thought about limiting interval reductions, but that means the
behaviour is inconsistent when sending a card forward and moving it
back again.

We could apply a cap to the amount of interval we'll reduce, but that
will either doing something like dividing by 2 (which breaks down when
the action is performed repeatedly), or or looking up the review log
to try and determine the previous interval we should not go below.

One other option we might want to consider in the future is using
the revlog to calculate the actual elapsed time at answer time instead
of reschedule time, falling back to existing behaviour when the revlog
doesn't match or is missing.
This commit is contained in:
Damien Elmes 2021-02-12 11:17:08 +10:00
parent a6f0c60ff8
commit b3b40933c2
1 changed files with 15 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
rslib/src/sched/reviews.rs
View file

@ -15,41 +15,20 @@ use regex::Regex;
impl Card { impl Card {
/// Make card due in `days_from_today`. /// Make card due in `days_from_today`.
/// If card is not a review card, convert it into one. /// If card is not a review card, convert it into one.
/// Relearning cards have their interval preserved. Normal review /// Review/relearning cards have their interval preserved unless
/// cards have their interval adjusted based on change between the /// `force_reset` is true.
/// previous and new due date.
fn set_due_date(&mut self, today: u32, days_from_today: u32, force_reset: bool) { fn set_due_date(&mut self, today: u32, days_from_today: u32, force_reset: bool) {
let new_due = (today + days_from_today) as i32; let new_due = (today + days_from_today) as i32;
let new_interval = if force_reset { let new_interval =
days_from_today if force_reset || !matches!(self.ctype, CardType::Review | CardType::Relearn) {
} else if let Some(old_due) = self.current_review_due_day() { days_from_today
// review cards have their interval shifted based on actual elapsed time } else {
let days_early = old_due - new_due; self.interval
((self.interval as i32) - days_early).max(0) as u32 };
} else if self.ctype == CardType::Relearn {
// We can't know how early or late this card entered relearning
// without consulting the revlog, which may not exist. If the user
// has their deck set up to reduce but not zero the interval on
// failure, the card may potentially have an interval of weeks or
// months, so we'll favour that if it's larger than the chosen
// `days_from_today`
self.interval.max(days_from_today)
} else {
// other cards are given a new starting interval
days_from_today
};
self.schedule_as_review(new_interval, new_due); self.schedule_as_review(new_interval, new_due);
} }
// For review cards not in relearning, return the day the card is due.
fn current_review_due_day(&self) -> Option<i32> {
match self.ctype {
CardType::New | CardType::Learn | CardType::Relearn => None,
CardType::Review => Some(self.original_or_current_due()),
}
}
fn schedule_as_review(&mut self, interval: u32, due: i32) { fn schedule_as_review(&mut self, interval: u32, due: i32) {
self.remove_from_filtered_deck_before_reschedule(); self.remove_from_filtered_deck_before_reschedule();
self.interval = interval.max(1); self.interval = interval.max(1);
@ -184,9 +163,7 @@ mod test {
// reschedule it again the next day, shifting it from day 7 to day 9 // reschedule it again the next day, shifting it from day 7 to day 9
c.set_due_date(6, 3, false); c.set_due_date(6, 3, false);
assert_eq!(c.due, 9); assert_eq!(c.due, 9);
// we moved it 2 days forward from its original 2 day interval, and the assert_eq!(c.interval, 2);
// interval should match the new delay
assert_eq!(c.interval, 4);
// we can bring cards forward too - return it to its original due date // we can bring cards forward too - return it to its original due date
c.set_due_date(6, 1, false); c.set_due_date(6, 1, false);
@ -194,11 +171,12 @@ mod test {
assert_eq!(c.interval, 2); assert_eq!(c.interval, 2);
// we can force the interval to be reset instead of shifted // we can force the interval to be reset instead of shifted
c.set_due_date(6, 2, true); c.set_due_date(6, 3, true);
assert_eq!(c.due, 8); assert_eq!(c.due, 9);
assert_eq!(c.interval, 2); assert_eq!(c.interval, 3);
// should work in a filtered deck // should work in a filtered deck
c.interval = 2;
c.original_due = 7; c.original_due = 7;
c.original_deck_id = DeckID(1); c.original_deck_id = DeckID(1);
c.due = -10000; c.due = -10000;
@ -210,20 +188,12 @@ mod test {
assert_eq!(c.original_due, 0); assert_eq!(c.original_due, 0);
assert_eq!(c.original_deck_id, DeckID(0)); assert_eq!(c.original_deck_id, DeckID(0));
// when relearning, a larger delay than the interval will win // relearning treated like review
c.ctype = CardType::Relearn; c.ctype = CardType::Relearn;
c.original_due = c.due; c.original_due = c.due;
c.due = 12345678; c.due = 12345678;
c.set_due_date(6, 10, false); c.set_due_date(6, 10, false);
assert_eq!(c.due, 16); assert_eq!(c.due, 16);
assert_eq!(c.interval, 10); assert_eq!(c.interval, 2);
// but a shorter delay will preserve the current interval
c.ctype = CardType::Relearn;
c.original_due = c.due;
c.due = 12345678;
c.set_due_date(6, 1, false);
assert_eq!(c.due, 7);
assert_eq!(c.interval, 10);
} }
} }